Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-nextcloud-exporter: 0.1.0 -> 0.3.0 #109634

Merged
merged 2 commits into from Jan 17, 2021
Merged

prometheus-nextcloud-exporter: 0.1.0 -> 0.3.0 #109634

merged 2 commits into from Jan 17, 2021

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/xperimental/nextcloud-exporter/releases/tag/v0.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @ajs124

WilliButz and others added 2 commits January 17, 2021 15:25
@WilliButz @ajs124
prometheus-nextcloud-exporter: 0.1.0 -> 0.3.0
1c224b9 
https://github.com/xperimental/nextcloud-exporter/releases/tag/v0.3.0

Co-authored-by: ajs124 <git@ajs124.de>
@WilliButz @ajs124
nixos/promtheus-nextcloud-exporter: update module and test
254b510 
Use new command-line flags of release 0.3.0 and always answer with the
expected XML in the VM test instead of using a test-specific fixed path.

Co-authored-by: ajs124 <git@ajs124.de>
@ofborg ofborg bot requested a review from kalbasit January 17, 2021 14:41
@Ma27 Ma27 merged commit 7efb6ae into NixOS:master Jan 17, 2021
@WilliButz WilliButz deleted the update/prometheus-nextcloud-exporter/0.3.0 branch January 25, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27