Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-pam: fix cross compilation on Darwin #109635

Merged
merged 1 commit into from Feb 3, 2021
Merged

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Jan 17, 2021

I need to cross compile some Linux packages on Darwin for use in a VM. Linux-PAM requires this fix, which I believe is straightforward. The reason is: during the PAM documentation build, a tool is created to run on the build machine. The code includes libintl.h. On Linux, this header comes with glibc, but on Darwin, gettext is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

A build-time tool is created, which requires libintl.h.
On Linux, libintl.h comes with glibc, but on Darwin, gettext is needed.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 17, 2021
@Mic92 Mic92 merged commit 60d9784 into NixOS:master Feb 3, 2021
@mroi mroi deleted the patch-pam branch February 3, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants