treewide: pkgconfig -> pkg-config #109595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
force-pushed
the
remove-pkgconfig
branch
from
fe38f33
to
e2b8726
Compare
|
Goal is rebuild 0. |
siraben
force-pushed
the
remove-pkgconfig
branch
from
c4d2023
to
63ef91e
Compare
ofborg
bot
added
6.topic: cinnamon
6.topic: GNOME
siraben
force-pushed
the
remove-pkgconfig
branch
from
63ef91e
to
2fddb2f
Compare
siraben
force-pushed
the
remove-pkgconfig
branch
from
2fddb2f
to
0d4fcbd
Compare
jonringer
reviewed
Jan 17, 2021
|
actually, the builds were quite fast. Going to merge this before it bit rots |
|
|
|
Remaining progress: |
|
thanks for doing this :). It was getting tiring to say "please use |
Same for me. Especially if people get pissed about it. |
10 tasks
jonringer
added a commit
to jonringer/nixpkgs
that referenced
this pull request
Jan 19, 2021
continuation of NixOS#109595 pkgconfig was aliased in 2018, however, it remained in all-packages.nix due to its wide usage. This cleans up the remaining references to pkgs.pkgsconfig and moves the entry to aliases.nix. python3Packages.pkgconfig remained unchanged because it's the canonical name of the upstream package on pypi.
jonringer
added a commit
that referenced
this pull request
Jan 19, 2021
continuation of #109595 pkgconfig was aliased in 2018, however, it remained in all-packages.nix due to its wide usage. This cleans up the remaining references to pkgs.pkgsconfig and moves the entry to aliases.nix. python3Packages.pkgconfig remained unchanged because it's the canonical name of the upstream package on pypi.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/pkgconfig-alias-has-been-officially-aliased/11066/2 |
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
May 12, 2021
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
Jul 23, 2021
Most of them are: * separate packages for different openmodelica components, * qt4 -> qt5, * patches to instruct the OMEdit wrapper with stdenv executables location, * adoption of NixOS#89731 and NixOS#109595, * openblas -> blas, lapack according to NixOS#83888, * parallel building, * getting rid of spurious build phases, * correct the license, * cross-compilation, * forcing compiler to clang++ according to OM build recommendations, * drop of pangox_compat according to NixOS#75909 and NixOS#76412, * better dependencies, and more.
balodja
added a commit
to balodja/nixpkgs
that referenced
this pull request
Jul 24, 2021
Co-authored-by: Jaakko Luttinen <jaakko.luttinen@iki.fi> Most of changes are: * separate packages for different openmodelica components, * qt4 -> qt5, * patches to instruct the OMEdit wrapper with stdenv executables location, * adoption of NixOS#89731 and NixOS#109595, * openblas -> blas, lapack according to NixOS#83888, * parallel building, * getting rid of spurious build phases, * correct the license, * cross-compilation, * forcing compiler to clang++ according to OM build recommendations, * drop of pangox_compat according to NixOS#75909 and NixOS#76412, * better dependencies, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pkg-configis the preferred naming.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)