Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/tools: pkgconfig -> pkg-config (2) #109613

Merged
merged 1 commit into from Jan 17, 2021
Merged

pkgs/tools: pkgconfig -> pkg-config (2) #109613

merged 1 commit into from Jan 17, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 17, 2021

Motivation for this change

Breaking up the change into ~1000 files changed PRs makes it more manageable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben marked this pull request as draft January 17, 2021 10:34
@siraben siraben marked this pull request as ready for review January 17, 2021 16:24
@siraben
Copy link
Member Author

siraben commented Jan 17, 2021

@SuperSandro2000 when you merge these treewide PRs please also merge master→staging-next→staging to reduce the chance of merge conflicts there.

@Mic92 Mic92 merged commit d87e126 into NixOS:master Jan 17, 2021
@siraben siraben deleted the pkgconfig-part2 branch January 17, 2021 17:09
@Mic92
Copy link
Member

Mic92 commented Jan 17, 2021

merged to staging-next/staging as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @Mic92 @SuperSandro2000