Fix: [OSX] Hide dock when entering fullscreen #8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
reviewed
Mar 1, 2021
src/video/cocoa/cocoa_v.mm
Outdated
| @@ -196,6 +196,7 @@ | |||
|
|
|||
| if ([ this->window respondsToSelector:@selector(toggleFullScreen:) ]) { | |||
| [ this->window performSelector:@selector(toggleFullScreen:) withObject:this->window ]; | |||
| [NSMenu setMenuBarVisible:!full_screen]; | |||
There was a problem hiding this comment.
Totally contrary to any guides by Apple, we tend to have lots of spaces on Obj-C.
Also, how nice from Apple that a function with menu bar in it's name hides the dock (while the official presentation mode apparently does not).
There was a problem hiding this comment.
Sorry, my Objective C experience is, frankly, minimal!
Something like this?
[ NSMenu setMenuBarVisible: !full_screen ];
There was a problem hiding this comment.
[ NSMenu setMenuBarVisible:!full_screen ]; i.e. spaces before and after brackets. Totally against any style guide 🤣
orudge
force-pushed
the
fix-macos-fullscreen
branch
from
73d3d7e
to
1a202d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
As per the last comment in #8038, the dock still appears if you hover over the bottom of the screen when in fullscreen mode.
Description
When switching into fullscreen mode, we hide both the menu and the dock programmatically. They are unhidden again when exiting full screen.
Limitations
None that I'm aware of.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.