Feature: [Actions / CMake] support for generic linux builds #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Feb 4, 2021
These bundles can be opened on any "modern" Linux machine with a driver that SDL2 supports. Machines needs at least glibc 2.15, which was released 10 years ago. It is build with CentOS 7 as base, and only assumes the following libraries are available on the system: - libc - libdl - libgcc_s - libpthread - librt - libstdc++ All other libraries the game depends on are bundled together with the game, so users don't need any library installed to use this bundle. The downside of course is that this increases the binary size a bit: 30 MiB of libraries are in this bundle. RPATH is used to make ld-linux find the folder libraries are stored in; however, system libraries are always used before these, in the assumption libraries on the user system are more up-to-date. Using -DOPTION_PACKAGE_DEPENDENCIES=ON switches on packaging of libraries in the "lib" folder. This requires CMake 3.16 to be installed; otherwise it will fail.
TrueBrain
force-pushed
the
generic-linux
branch
from
599f242
to
401d3e7
Compare
nielsmh
reviewed
Feb 5, 2021
Comment on lines
+304
to
+308
| # The yum variant of fluidsynth depends on all possible audio drivers. | ||
| # This is not really useful for us, as that would require a user to | ||
| # have them all before he can start OpenTTD. Instead, compile a | ||
| # version that can only use SDL2. As OpenTTD does sound via SDL2, | ||
| # this simply means we either have sound and music, or have none. |
There was a problem hiding this comment.
This is incorrect. OpenTTD does not depend on fluidsynth having output via a sound driver at all. The fluidsynth music driver sets up fluidsynth to call an internal callback to deliver samples, which are then mixed by our own sound mixer. If it's possible to build fluidsynth without any output drivers at all, you may as well do that.
OpenTTD/src/music/fluidsynth.cpp
Lines 68 to 71 in a667ed9
TrueBrain
added a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Feb 5, 2021
nielsmh nicely correct us in OpenTTD#8641, pointing out the old comment is not telling a complete truth. The result, is the same, but it is better to not mislead future-us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
For Steam we would like to have a Linux release too. As we didn't build a generic linux build yet, this was a bit of a challenge ;)
Description
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.