Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: 15.2.7 -> 15.2.8 #109286

Merged
merged 1 commit into from Jan 15, 2021
Merged

ceph: 15.2.7 -> 15.2.8 #109286

merged 1 commit into from Jan 15, 2021

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jan 13, 2021

Motivation for this change

Although we probably aren't affected by: CVE-2020-27781, we might as well just get nixpkgs bumped to latest minor release.
this PR closes #109151 (if also backported to 20.09)

Regarding the boost bump: ceph v15.2.8 no longer builds with boost v1.6X, because of this change: ceph/ceph@5d5f9a0 and it doesn't build with latest boost (1.75) either. The choice of v1.72 is based on the ceph cmake-files selecting that version, although I also tested it working fine with 1.73.
(https://github.com/ceph/ceph/blob/v15.2.8/cmake/modules/BuildBoost.cmake#L151)

The single-node and multi-node tests passed locally on my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Jan 13, 2021 •
edited

boost172 is the latest 1.7x in 20.09 as well, so that seems like a good choice for multiple reasons. Waiting for tests to pass.

@srhb srhb added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 13, 2021
@ofborg ofborg bot requested review from adevress and krav January 13, 2021 15:24
@srhb
Copy link
Contributor

srhb commented Jan 13, 2021

Oh, right, still broken in passthru.

@GrahamcOfBorg test ceph-multi-node ceph-single-node

@srhb
Copy link
Contributor

srhb commented Jan 15, 2021 

1 package marked as broken and skipped:
bareos

1 package failed to build:
sambaFull

3 packages built:
ceph ceph-client libceph

and sambaFull was already broken. LGTM

@srhb srhb merged commit c6c1319 into NixOS:master Jan 15, 2021
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Jan 15, 2021
@srhb
ceph: 15.2.7 -> 15.2.8
fd0986b 
(cherry picked from commit 423b9b2)
Backport of NixOS#109286
@srhb srhb mentioned this pull request Jan 15, 2021
Merged
10 tasks
erictapen pushed a commit that referenced this pull request Jan 16, 2021
@erictapen
ceph: 15.2.7 -> 15.2.8
c7aa077 
(cherry picked from commit 423b9b2)
Backport of #109286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adevress adevress Awaiting requested review from adevress

@krav krav Awaiting requested review from krav

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 98: ceph-15.2.7: 1 advisory [7.1]
2 participants
@johanot @srhb