Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare2: Minor cleaning in expression #109304

Merged
merged 1 commit into from Jan 14, 2021
Merged

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Keep the expression simple.
Upstream is fixed: Removing this line does not break the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Poke @Mic92

Signed-off-by: Pamplemousse xav.maso@gmail.com

Upstream is fixed: Removing this line does not break the build.

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 13, 2021

Result of nixpkgs-review pr 109304 run on x86_64-linux 1

6 packages built:
  • python37Packages.r2pipe
  • python38Packages.r2pipe
  • python39Packages.r2pipe
  • r2-for-cutter
  • radare2
  • radare2-cutter

Still builds, still runs.

@Mic92 Mic92 merged commit ff22087 into NixOS:master Jan 14, 2021
@Pamplemousse Pamplemousse deleted the radare2 branch May 15, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants