Fix #7670: Cache the origin tile to prevent recurring calls to the road pathfinder when a vehicle is blocked by another #7822
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
fc4d6b1 to
dee9710
Compare
nielsmh
previously requested changes
Feb 9, 2020
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
dee9710 to
d9c7987
Compare
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
d9c7987 to
bb267f8
Compare
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
bb267f8 to
ca05e3c
Compare
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
ca05e3c to
3948e28
Compare
TrueBrain
added
candidate: probably not
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
2 times, most recently
from
8de304c to
3fe07ea
Compare
… the road pathfinder when a vehicle is blocked by another
SamuXarick
force-pushed
the
blocked-road-vehicle-yapf-fix
branch
from
3fe07ea to
2be4c78
Compare
|
Just retested this as of current master (and on a new CPU). Without fix: pathfinder is called every tick With fix: pathfinder is called once |
|
I think master...glx22:fix_7670 has the same effect without requiring savegame bump. |
|
Superseded by #8568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix for #7670 , but not fully tested. I thought of caching the origin of where the pathfind starts its search. It seems to solve the issue, but I'm not sure this is the right approach.
Problem is best explained here: #7670 (comment)
savegame for testing, requires only 2 vehicles and a giant road network to trigger the issue : https://github.com/OpenTTD/OpenTTD/files/3801034/2.vehicles.only.zip