[Not for formal review] Update cull rect before paint (behind runtime flag) #27172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flag) This is mainly for CompositeAfterPaint to fix the issue of always repainting on scroll. By updating cull rect before paint, we know which layer will change cull rect and needs repaint. This will also simplify interest rect and cull rect calculation and repaint on their change in pre-CompositeAfterPaint. It will unify composited layer interest rect calculation and LayoutObject cull rect calculation, and avoid whole subtree repaint on clip change. Bug: 1046544 Change-Id: I7f830016293af6ce93f0bcd14ac309efeb9f7068
wpt-pr-bot
approved these changes
Jan 13, 2021
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for CompositeAfterPaint to fix the issue of always
repainting on scroll. By updating cull rect before paint, we know which
layer will change cull rect and needs repaint.
This will also simplify interest rect and cull rect calculation and
repaint on their change in pre-CompositeAfterPaint. It will unify
composited layer interest rect calculation and LayoutObject cull rect
calculation, and avoid whole subtree repaint on clip change.
Bug: 1046544
Change-Id: I7f830016293af6ce93f0bcd14ac309efeb9f7068
Reviewed-on: https://chromium-review.googlesource.com/2615578
WPT-Export-Revision: 54762edd77ef53499864cdace9b0256260fe07e9