Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluxcd: 0.5.0 -> 0.5.9 #109260

Merged
merged 1 commit into from Jan 13, 2021
Merged

fluxcd: 0.5.0 -> 0.5.9 #109260

merged 1 commit into from Jan 13, 2021

Conversation

ymatsiuk
Copy link
Contributor

@ymatsiuk ymatsiuk commented Jan 13, 2021 •
edited

Motivation for this change

version bump, changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymatsiuk
Copy link
Contributor Author 

1 package updated:
fluxcd (0.5.0 → 0.5.9)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/ymatsiuk/.cache/nixpkgs-review/pr-109260/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/109260

1 package built:
fluxcd

@ofborg ofborg bot requested review from jlesquembre and kalbasit January 13, 2021 10:18
@fabaff
Copy link
Member

fabaff commented Jan 13, 2021

Result of nixpkgs-review pr 109260 run on x86_64-linux 1

1 package built:
  • fluxcd

fabaff
fabaff approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

...r-109260/results]$ ./fluxcd/bin/flux
Command line utility for assembling Kubernetes CD pipelines the GitOps way.

Usage:
  flux [command]

Examples:
  # Check prerequisites
[...]

Looks good to me.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109260 run on x86_64-darwin 1

1 package built:
  • fluxcd

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109260 run on x86_64-linux 1

1 package built:
  • fluxcd

@SuperSandro2000 SuperSandro2000 merged commit a76f069 into NixOS:master Jan 13, 2021
@ymatsiuk ymatsiuk deleted the flux2bump branch January 13, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ymatsiuk @fabaff @SuperSandro2000