Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.faker: 4.18.0 -> 5.5.1 #109269

Merged
merged 2 commits into from Jan 14, 2021
Merged

python3Packages.faker: 4.18.0 -> 5.5.1 #109269

merged 2 commits into from Jan 14, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 13, 2021

Motivation for this change

Update to latest upstream release 5.5.1.

Changelog: https://github.com/joke2k/faker/blob/master/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lovek323 January 13, 2021 12:00
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109269 run on x86_64-darwin 1

11 packages marked as broken and skipped:
  • gscan2pdf
  • mailman-web
  • odpdown
  • python37Packages.mailman-web
  • python37Packages.rl-coach
  • python37Packages.toggl-cli
  • python38Packages.mailman-web
  • python38Packages.rl-coach
  • python38Packages.toggl-cli
  • python39Packages.mailman-web
  • python39Packages.toggl-cli
13 packages failed to build and are new build failures:
72 packages built:
  • flexget
  • noto-fonts-emoji
  • photon
  • python37Packages.Quandl (python37Packages.quandl)
  • python37Packages.afdko
  • python37Packages.booleanoperations
  • python37Packages.defcon
  • python37Packages.factory_boy
  • python37Packages.faker
  • python37Packages.flask-restx
  • python37Packages.fontmath
  • python37Packages.fontparts
  • python37Packages.fontpens
  • python37Packages.fonttools
  • python37Packages.minio
  • python37Packages.mutatormath
  • python37Packages.nototools
  • python37Packages.psautohint
  • python37Packages.pytest-factoryboy
  • python37Packages.pytest-randomly
  • python37Packages.scrapy-fake-useragent
  • python37Packages.sslyze
  • python37Packages.tld
  • python37Packages.ufoprocessor
  • python38Packages.Quandl (python38Packages.quandl)
  • python38Packages.afdko
  • python38Packages.booleanoperations
  • python38Packages.defcon
  • python38Packages.factory_boy
  • python38Packages.faker
  • python38Packages.flask-restx
  • python38Packages.fontmath
  • python38Packages.fontparts
  • python38Packages.fontpens
  • python38Packages.fonttools
  • python38Packages.minio
  • python38Packages.mutatormath
  • python38Packages.nototools
  • python38Packages.psautohint
  • python38Packages.pytest-factoryboy
  • python38Packages.pytest-randomly
  • python38Packages.scrapy-fake-useragent
  • sslyze (python38Packages.sslyze)
  • python38Packages.tld
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.booleanoperations
  • python39Packages.defcon
  • python39Packages.factory_boy
  • python39Packages.faker
  • python39Packages.flask-restx
  • python39Packages.fontmath
  • python39Packages.fontparts
  • python39Packages.fontpens
  • python39Packages.fonttools
  • python39Packages.minio
  • python39Packages.mutatormath
  • python39Packages.nototools
  • python39Packages.psautohint
  • python39Packages.pytest-factoryboy
  • python39Packages.pytest-randomly
  • python39Packages.scrapy-fake-useragent
  • python39Packages.sslyze
  • python39Packages.tld
  • python39Packages.ufoprocessor
  • rictydiminished-with-firacode
  • scfbuild
  • sourcehut.gitsrht
  • sourcehut.todosrht
  • visidata
  • xits-math
  • xquartz

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.ufoprocessor:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.ufoprocessor:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.ufoprocessor:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2021 •
edited

It is weired that your django builds get PermissionError: [Errno 1] Operation not permitted: '/usr/share/zoneinfo' instead of a file not found.

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2021

I suppose this has something to do with darwin's sandbox? cc @LnL7 ?

@SuperSandro2000
Copy link
Member

I suppose this has something to do with darwin's sandbox? cc @LnL7 ?

Yes, it is.

Also I can't build this PR on linux because it tries to build the kernel.

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2021

When building only python packages this is the result:

Result of nixpkgs-review pr 109269 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • python37Packages.rl-coach
  • python37Packages.skein
  • python37Packages.zake
  • python38Packages.rl-coach
  • python38Packages.skein
  • python38Packages.zake
  • python39Packages.skein
  • python39Packages.zake
12 packages failed to build:
  • python37Packages.foundationdb60
  • python37Packages.foundationdb61
  • python37Packages.pylint-django
  • python37Packages.slither-analyzer
  • python38Packages.foundationdb60
  • python38Packages.foundationdb61
  • python38Packages.pylint-django
  • python38Packages.slither-analyzer
  • python39Packages.django_silk
  • python39Packages.foundationdb60
  • python39Packages.foundationdb61
  • python39Packages.slither-analyzer
95 packages built:
  • python37Packages.Quandl (python37Packages.quandl)
  • python37Packages.afdko
  • python37Packages.booleanoperations
  • python37Packages.cnvkit
  • python37Packages.defcon
  • python37Packages.django_extensions
  • python37Packages.django_silk
  • python37Packages.factory_boy
  • python37Packages.faker
  • python37Packages.flask-restx
  • python37Packages.fontmath
  • python37Packages.fontparts
  • python37Packages.fontpens
  • python37Packages.fonttools
  • python37Packages.foundationdb51
  • python37Packages.foundationdb52
  • python37Packages.hyperkitty
  • python37Packages.kazoo
  • python37Packages.mailman-web
  • python37Packages.minio
  • python37Packages.monosat
  • python37Packages.mutatormath
  • python37Packages.nototools
  • python37Packages.psautohint
  • python37Packages.pytest-factoryboy
  • python37Packages.pytest-randomly
  • python37Packages.qiskit
  • python37Packages.qiskit-aqua
  • python37Packages.rpy2
  • python37Packages.scrapy-fake-useragent
  • python37Packages.sslyze
  • python37Packages.tld
  • python37Packages.toggl-cli
  • python37Packages.ufoprocessor
  • python38Packages.Quandl (python38Packages.quandl)
  • python38Packages.afdko
  • python38Packages.booleanoperations
  • python38Packages.cnvkit
  • python38Packages.defcon
  • python38Packages.django_extensions
  • python38Packages.django_silk
  • python38Packages.factory_boy
  • python38Packages.faker
  • python38Packages.flask-restx
  • python38Packages.fontmath
  • python38Packages.fontparts
  • python38Packages.fontpens
  • python38Packages.fonttools
  • python38Packages.foundationdb51
  • python38Packages.foundationdb52
  • python38Packages.hyperkitty
  • python38Packages.kazoo
  • python38Packages.mailman-web
  • python38Packages.minio
  • python38Packages.monosat
  • python38Packages.mutatormath
  • python38Packages.nototools
  • python38Packages.psautohint
  • python38Packages.pytest-factoryboy
  • python38Packages.pytest-randomly
  • python38Packages.qiskit
  • python38Packages.qiskit-aqua
  • python38Packages.rpy2
  • python38Packages.scrapy-fake-useragent
  • python38Packages.sslyze
  • python38Packages.tld
  • python38Packages.toggl-cli
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.booleanoperations
  • python39Packages.defcon
  • python39Packages.django_extensions
  • python39Packages.factory_boy
  • python39Packages.faker
  • python39Packages.flask-restx
  • python39Packages.fontmath
  • python39Packages.fontparts
  • python39Packages.fontpens
  • python39Packages.fonttools
  • python39Packages.foundationdb51
  • python39Packages.foundationdb52
  • python39Packages.hyperkitty
  • python39Packages.kazoo
  • python39Packages.mailman-web
  • python39Packages.minio
  • python39Packages.monosat
  • python39Packages.mutatormath
  • python39Packages.nototools
  • python39Packages.psautohint
  • python39Packages.pytest-factoryboy
  • python39Packages.pytest-randomly
  • python39Packages.scrapy-fake-useragent
  • python39Packages.sslyze
  • python39Packages.tld
  • python39Packages.ufoprocessor

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2021

Broken python packages are also broken on master:

✖ (Dependency failed) python3.7-foundationdb-6.0.18 from 2021-01-13 - https://hydra.nixos.org/build/135046768
✖ (Failed) python3.7-pylint-django-2.3.0 from 2021-01-11 - https://hydra.nixos.org/build/134824122
✖ (Dependency failed) python3.8-slither-analyzer-0.7.0 from 2021-01-13 - https://hydra.nixos.org/build/135031118

@Mic92 Mic92 merged commit 04510db into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @Mic92