Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruffle: nightly-2020-11-30 -> nightly-2021-01-12 #109271

Merged
merged 1 commit into from Jan 22, 2021
Merged

ruffle: nightly-2020-11-30 -> nightly-2021-01-12 #109271

merged 1 commit into from Jan 22, 2021

Conversation

eduardosm
Copy link
Contributor

@eduardosm eduardosm commented Jan 13, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eduardosm
Copy link
Contributor Author

Result of nixpkgs-review pr 109271 run on x86_64-linux 1

1 package built:
  • ruffle

@ofborg ofborg bot requested a review from GovanifY January 13, 2021 12:23
GovanifY
GovanifY approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@GovanifY GovanifY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wanted to do the PR but didn't had the time recently

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109271 run on x86_64-linux 1

1 package built:
  • ruffle

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/446

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from GovanifY January 22, 2021 00:39
@SuperSandro2000 SuperSandro2000 merged commit fd0daed into NixOS:master Jan 22, 2021
@eduardosm eduardosm deleted the ruffle branch January 25, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@GovanifY GovanifY Awaiting requested review from GovanifY

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eduardosm @SuperSandro2000 @nixos-discourse @GovanifY