Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mopidy-youtube: 3.1 -> 3.2 #109317

Merged
merged 1 commit into from Jan 14, 2021
Merged

mopidy-youtube: 3.1 -> 3.2 #109317

merged 1 commit into from Jan 14, 2021

Conversation

hexop
Copy link

@hexop hexop commented Jan 13, 2021

Motivation for this change

3.2 was released upstream which resolves natumbri/mopidy-youtube#158

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've tested it using this overlay:

  let latest-mopidy-youtube = pkgs.mopidy-youtube.overrideAttrs (old: rec {
    pname = "mopidy-youtube";
    version = "3.2";

    src = pkgs.python3Packages.fetchPypi {
      inherit version;
      pname = "Mopidy-YouTube";
      sha256 = "0wmalfqnskglssq3gj6kkrq6h6c9yab503y72afhkm7n9r5c57zz";
    };
  });

I believe that this is not optimal for reviewing, would it be better to build using buildEnv, as I've seen in this PR #93808 ?

I've been running it for a few days and it works perfectly.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109317 run on x86_64-linux 1

1 package built:
  • mopidy-youtube

@SuperSandro2000 SuperSandro2000 merged commit cebcc7a into NixOS:master Jan 14, 2021
@hexop hexop deleted the mopidy-youtube branch January 14, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube can play music but not searching
3 participants