Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quake3hires: init at 2020-05-07 #109315

Merged
merged 1 commit into from Jan 18, 2021
Merged

quake3hires: init at 2020-05-07 #109315

merged 1 commit into from Jan 18, 2021

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

High resolution texture pack for Quake3 from https://ioquake3.org/extras/replacement_content/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 14, 2021
View reviewed changes
pkgs/games/quake3/content/hires.nix Outdated Show resolved Hide resolved
pkgs/games/quake3/content/hires.nix Outdated Show resolved Hide resolved
pkgs/games/quake3/content/hires.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 14, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109315 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • quake3hires: log was empty
'/nix/store/gbgzzjsy4s03y24l16jf874ndjdyqrhq-source.drv' failed with exit code 1; last 7 log lines:                                                                                                                                                                                                                                                                           trying https://ioquake3.org/files/xcsv_hires.zip                                                                                                                                              % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404
  error: cannot download source from any mirror
cannot build derivation '/nix/store/zg4absbcbzhmvbdsyma3zg5iq4pa54p6-quake3hires-2020-05-07.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w98sg1jhr09lrj4k1f05iw1qbpc1x5mi-env.drv': 1 dependencies couldn't be built

@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 14, 2021 18:54
@rvolosatovs rvolosatovs marked this pull request as ready for review January 18, 2021 16:15
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build quake3hires

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109315 run on x86_64-linux 1

1 package built:
  • quake3hires

@SuperSandro2000 SuperSandro2000 merged commit 2d46134 into NixOS:master Jan 18, 2021
@rvolosatovs rvolosatovs deleted the init/quake3hires branch September 6, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvolosatovs @SuperSandro2000