Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] lvm2: 2.03.10 -> 2.03.11 #109243

Merged
merged 1 commit into from Jan 16, 2021
Merged

[staging] lvm2: 2.03.10 -> 2.03.11 #109243

merged 1 commit into from Jan 16, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 13, 2021

Motivation for this change

https://github.com/lvmteam/lvm2/blob/v2_03_11/WHATS_NEW

VDO support is built by default now,
but is disabled in nixpkgs, because it can't find vdoformat.
AFAICT the kernel support for that still isn't upstream and it still
seems kind of experimental, so I'd just ignore that for now and add it
once it's either upstream of if anyone actually wants to use it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
lvm2: 2.03.10 -> 2.03.11
d6fcb76 
https://github.com/lvmteam/lvm2/blob/v2_03_11/WHATS_NEW

[VDO](https://github.com/dm-vdo/vdo) support is built by default now,
but is disabled in nixpkgs, because it can't find `vdoformat`.
AFAICT the kernel support for that still isn't upstream and it still
seems kind of experimental, so I'd just ignore that for now and add it
once it's either upstream of if anyone actually wants to use it.
@ajs124 ajs124 mentioned this pull request Jan 13, 2021
Closed
10 tasks
@ofborg ofborg bot requested a review from 7c6f434c January 13, 2021 04:20
@jonringer jonringer changed the title lvm2: 2.03.10 -> 2.03.11 [staging] lvm2: 2.03.10 -> 2.03.11 Jan 13, 2021
@jonringer
Copy link
Contributor

@GrahamcOfBorg test firefox

@ajs124
Copy link
Member Author

ajs124 commented Jan 13, 2021

@jonringer Why firefox? ^^

@jonringer
Copy link
Contributor

good question, I think my line of reasoning was, "if firefox builds, anything would build". but it is a dependency:

nix-store --query --requisites $(nix-instantiate -A firefox) | grep lvm2
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/gmdqchkhlil1d8jly9zpxirh16ddw7qz-lvm2-2.03.10.drv

@jonringer jonringer merged commit 2982fa4 into NixOS:staging Jan 16, 2021
@ajs124 ajs124 deleted the upd/lvm2 branch January 16, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @jonringer