Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick: 6.9.11-29 -> 6.9.11-57 #109244

Closed
wants to merge 2 commits into from
Closed

imagemagick: 6.9.11-29 -> 6.9.11-57 #109244

wants to merge 2 commits into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 13, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request Jan 23, 2021
Closed
10 tasks
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 23, 2021
@dotlambda
Copy link
Member

See #109184 and #100302.
According to https://nvd.nist.gov/vuln/detail/CVE-2020-29599, this fixes at least CVE-2020-29599.

SuperSandro2000
SuperSandro2000 reviewed Jan 23, 2021
View reviewed changes
pkgs/applications/graphics/ImageMagick/default.nix
// lib.optionalAttrs (stdenv.hostPlatform.isMinGW) {
version = "6.9.2-0";
sha256 = "17ir8bw1j7g7srqmsz3rx780sgnc21zfn0kwyj78iazrywldx8h7";
patches = [(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove fetchpatch from inputs.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109244 run on x86_64-darwin 1

1 package built:
  • imagemagick

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

imagemagick:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Magick++-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Magick++-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Magick-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Magick-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/MagickCore-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/MagickCore-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/MagickWand-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/MagickWand-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Wand-config'
substituteStream(): WARNING: pattern '/nix/store/8d70a1dc03f1j4lvddf66faahnrg4bzy-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/mcxksaa14i9m2d16z80dp87b4mz10nrg-imagemagick-6.9.11-57-dev/bin/Wand-config'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109244 run on x86_64-linux 1

1 package built:
  • imagemagick

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

imagemagick:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Magick++-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Magick++-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Magick-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Magick-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/MagickCore-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/MagickCore-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/MagickWand-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/MagickWand-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config -config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Wand-config'
substituteStream(): WARNING: pattern '/nix/store/pjrkzmdm3p93r2la8j5bvksh5cq84535-pkg-config-wrapper-0.29.2/bin/pkg-config' doesn't match anything in file '/nix/store/74pfrls4dp38330bvxkgaiqapn17mqqx-imagemagick-6.9.11-57-dev/bin/Wand-config'

Please check the offending substituteInPlace for typos or changes in source.

@dotlambda
Copy link
Member

closing in favour of #111287

@dotlambda dotlambda closed this Jan 30, 2021
@ajs124 ajs124 deleted the upd/imagemagick6 branch March 11, 2021 16:23
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @dotlambda @SuperSandro2000 @TredwellGit