Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate revision in name for Dhall GitHub packages #109338

Merged
merged 3 commits into from Jan 15, 2021
Merged

Incorporate revision in name for Dhall GitHub packages #109338

merged 3 commits into from Jan 15, 2021

Conversation

Gabriella439
Copy link
Contributor

This is a small quality-of-life improvement so that
the package version/revision can be inferred from the
/nix/store path (which is the convention for most of the
Nixpkgs ecosystem).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gabriella439
Incorporate revision in name for Dhall GitHub packages
42cd596 
This is a small quality-of-life improvement so that
the package version/revision can be inferred from the
/nix/store path (which is the convention for most of the
Nixpkgs ecosystem).
@Gabriella439
Copy link
Contributor Author

cc: @ehmry

Also, I apologize for the pings. Perhaps you should be a code owner for Dhall stuff so that I don't need to ping you for reviews. I don't really know how the Nixpkgs code review system works

@ehmry ehmry merged commit df69951 into NixOS:master Jan 15, 2021
@ehmry
Copy link
Contributor

ehmry commented Jan 15, 2021

Good idea. No worries about the pings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gabriella439 @ehmry