Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#572: add option to suppress generated verilog attributes #576

Closed
wants to merge 1 commit into from
Closed

Conversation

hansfbaier
Copy link

I reduced it to the minimum:
I think it is really necessary for verilog, because the attributes cause a plethora of warnings
in Quartus. Actually I would suggest default=true, because of this.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #576 (304ad1f) into master (9af8201) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          49       49           
  Lines        6461     6461           
  Branches     1287     1287           
=======================================
  Hits         5266     5266           
+ Misses       1008     1007    -1     
- Partials      187      188    +1     
Impacted Files Coverage Δ
nmigen/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af8201...304ad1f. Read the comment docs.

@whitequark whitequark deleted the branch amaranth-lang:master December 10, 2021 08:51
@whitequark whitequark closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants