Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reaper: 6.12c -> 6.19 #109293

Merged
merged 4 commits into from Jan 14, 2021
Merged

reaper: 6.12c -> 6.19 #109293

merged 4 commits into from Jan 14, 2021

Conversation

ilian
Copy link
Member

@ilian ilian commented Jan 13, 2021

Motivation for this change

Update Reaper to version 6.19.

Changelog: https://www.reaper.fm/whatsnew.txt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ilian ilian requested a review from infinisil January 13, 2021 16:41
@ofborg ofborg bot requested a review from jfrankenau January 13, 2021 17:40
hugolgst
hugolgst reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you split c05a9b2 into:

  • maintainers: add ilian
  • bonzomatic: update maintainers
  • rpcs3: update maintainers

Otherwise, the package update looks good to me.

@hugolgst
Copy link
Member

Result of nixpkgs-review pr 109293 1

1 package built:
  • reaper

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109293 run on x86_64-linux 1

1 package built:
  • reaper

infinisil
infinisil approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 😀

@infinisil infinisil merged commit 7ddb893 into NixOS:master Jan 14, 2021
@ilian
Copy link
Member Author

ilian commented Jan 14, 2021

Thanks for the fast review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst left review comments

@infinisil infinisil infinisil approved these changes

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ilian @hugolgst @SuperSandro2000 @infinisil