Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/droidcam: init #109267

Merged
merged 2 commits into from Apr 5, 2021
Merged

nixos/droidcam: init #109267

merged 2 commits into from Apr 5, 2021

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jan 13, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested, but generally LGTM 👍

Should we add a NixOS test to make sure the kernel module stuff is all working (ie. the app doesn't crash)? Maybe? I'm not sure if that provides much value or not...

nixos/modules/programs/droidcam.nix Outdated Show resolved Hide resolved
bachp
bachp requested changes Mar 6, 2021
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module workes after I applied the requested changes.

nixos/modules/programs/droidcam.nix Outdated Show resolved Hide resolved
nixos/modules/programs/droidcam.nix Outdated Show resolved Hide resolved
@suhr @bachp
Apply suggestions from code review
a367ebf 
Co-authored-by: Pascal Bach <pascal.bach@nextrem.ch>
@bachp
Copy link
Member

bachp commented Mar 12, 2021

@suhr please squash the commits together

@SuperSandro2000 SuperSandro2000 merged commit 1517e6a into NixOS:master Apr 5, 2021
@suhr suhr deleted the droidcam-module branch April 5, 2021 19:36
cideM pushed a commit to cideM/nixpkgs that referenced this pull request Apr 9, 2021
@suhr @bachp @cideM
nixos/droidcam: init (NixOS#109267)
274ca6f 
Co-authored-by: Pascal Bach <pascal.bach@nextrem.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@aanderse aanderse aanderse left review comments

@bachp bachp bachp approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suhr @bachp @SuperSandro2000 @aanderse