New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usbguard: 0.7.8 -> 1.0.0 #109296
usbguard: 0.7.8 -> 1.0.0 #109296
Conversation
Result of 1 package built:
|
If you could do some in-depth testing to make sure building from source hasn't broken anything that'd be greatly appreciated @tnias 🙂 |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 55:
++ lib.optional libgcrypt
++ lib.optional libsodium;
line 64:
++ lib.optional "--with-crypto-library=gcrypt"
++ lib.optional "--with-crypto-library=sodium";
I could successfully build and use this patch (d7cd8d7). I tested basic functionality. This includes the new CLI partial rule feature, that was introduced in this release. |
Not sure what this means 😅 |
I can't write review comments on those lines but on a second look that won't work because we have no flag to enable something. It should be fine like this for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when the ? null
in the inputs are removed.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Motivation for this change
@tnias
Bump usbguard to
1.0.0
, build "fully" from source*,nixpkgs-fmt
, addlongDescription
* (was previously built from source + pre-bundled with the submodules and some autoconfig)
Contents:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)