Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sam-cli: fix dependency version bounds #109247

Closed
wants to merge 2 commits into from
Closed

aws-sam-cli: fix dependency version bounds #109247

wants to merge 2 commits into from

Conversation

lrworth
Copy link
Contributor

@lrworth lrworth commented Jan 13, 2021

Motivation for this change

aws-sam-cli places over-restrictive bounds on its python dependencies. Bumping for a recent version of nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JackKelly-Bellroy
JackKelly-Bellroy reviewed Jan 13, 2021
View reviewed changes
Copy link

@JackKelly-Bellroy JackKelly-Bellroy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix build '(import (builtins.fetchTarball 'https://github.com/lrworth/nixpkgs/archive/fix-aws-sam-cli.tar.gz') {}).aws-sam-cli' on NixOS.

@ofborg ofborg bot requested review from andreabedini and lo1tuma January 13, 2021 05:51
@jonringer
Copy link
Contributor

I would prefer to do #109067, just based on previous conversations I've had with the aws-sam-cli team

@lrworth
Copy link
Contributor Author

lrworth commented Jan 13, 2021

Thanks @jonringer, that looks like a better move.

@lrworth lrworth closed this Jan 13, 2021
@lrworth lrworth deleted the fix-aws-sam-cli branch January 13, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackKelly-Bellroy JackKelly-Bellroy JackKelly-Bellroy left review comments

@andreabedini andreabedini Awaiting requested review from andreabedini

@lo1tuma lo1tuma Awaiting requested review from lo1tuma

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lrworth @jonringer @JackKelly-Bellroy