Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube3d: k3sVersion 1.19.4-k3s1 -> 1.20.0+k3s2 #109253

Merged
merged 1 commit into from Jan 20, 2021

Conversation

giolekva
Copy link
Contributor

No description provided.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109253 run on x86_64-linux 1

1 package built:
  • kube3d

@giolekva
Copy link
Contributor Author

Ping

@SuperSandro2000
Copy link
Member

You are sure this does not require any hash changes?

@giolekva
Copy link
Contributor Author

This PR does not change the version of k3d to download and build, hence no hash change required.
The way k3d works is, it downloads prebuilt k3s on first use and I'm bumping up the k3s version not k3d.

@SuperSandro2000 SuperSandro2000 merged commit 11736bd into NixOS:master Jan 20, 2021
@jlesquembre
Copy link
Member

@SuperSandro2000 the hash needs no change because that is the version of the docker image to be used by kube3d cli, which happens at run time.

@giolekva thanks for this PR. It makes a lot of sense that you want to use the latest k3s version, but I think we should keep the same k3d version used upstream. It's easy to pick a different version with the k3d cli if you need to

But maybe be should make it easier to override the k3s version in the derivation, in case you want to use a different one.
I suggest to do this:

{ lib, buildGoModule, fetchFromGitHub, installShellFiles
,  k3sVersion? "1.19.4-k3s1" }:

and delete this:

let
  k3sVersion = "1.19.4-k3s1";
in

with those changes, you can do this to override the default k3s version:

pkgs.kube3d.override { k3sVersion = "1.20.0-k3s2"; };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants