Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

katago 1.6.1 -> 1.8.0 #109339

Merged
merged 1 commit into from Jan 15, 2021
Merged

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

Version update. Support for online contribution. Added documentation to wiki.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OmnipotentEntity
Copy link
Contributor Author

OmnipotentEntity commented Jan 14, 2021

Not ready to merge. Trying to figure out how to properly get a git revision from a tag. What I have doesn't work currently, and what I had before ofborg doesn't like.

For reference I previous had (builtins.fetchgit { url = "foo"; ref = "a tag"; }).rev, but because it is impure ofborg doesn't like it. And sha256 isn't supported by this function.

@OmnipotentEntity
Copy link
Contributor Author

I manually used the commit hash instead. I've already spent several hours trying to save myself several seconds a month.

pkgs/games/katago/default.nix Outdated Show resolved Hide resolved
pkgs/games/katago/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

I manually used the commit hash instead. I've already spent several hours trying to save myself several seconds a month.

This is a common way to do this.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109339 run on x86_64-linux 1

3 packages built:
  • katago
  • katagoCPU
  • katagoWithCuda

@OmnipotentEntity
Copy link
Contributor Author

OmnipotentEntity commented Jan 14, 2021

Gross. fixing.

This is what I get for not rebasing onto master for a month. Performed a manual rebase, testing before pushing.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109339 run on x86_64-linux 1

3 packages built:
  • katago
  • katagoCPU
  • katagoWithCuda

@SuperSandro2000 SuperSandro2000 merged commit 9faf158 into NixOS:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants