Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox][css-grid] move tests from vendor-imports #27174

Merged
merged 1 commit into from Jan 14, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented Jan 13, 2021

Links are updated as recommended by dholbert:
#26884 (comment)

Part of #8615.

Fixes #26884.

Links are updated as recommended by dholbert:
#26884 (comment)

Part of #8615.

Fixes #26884.
@foolip
Copy link
Member Author

foolip commented Jan 13, 2021

I'm fairly sure I managed to move the tests without breaking them by comparing the number of tests and failures in these two views:
https://wpt.fyi/results/css?sha=8e78617565&label=pr_head
https://wpt.fyi/results/css/vendor-imports/mozilla/mozilla-central-reftests/align3?sha=c9bb4ac8ec&label=master

@foolip
Copy link
Member Author

foolip commented Jan 13, 2021

Note that I added the css/css-flexbox/abspos/ directory, which didn't exist before, following the pattern of css/css-grid/abspos/. If this renaming is merged, I also have a follow-up to move more existing tests in css/css-flexbox/ into this directory.

@foolip foolip merged commit 526de41 into master Jan 14, 2021
@foolip foolip deleted the foolip/vendor-imports-align branch January 14, 2021 13:01
foolip added a commit that referenced this pull request Jan 14, 2021
Now that a abspos/ directly exists, move additional tests that list
https://drafts.csswg.org/css-flexbox/#abspos-items as their only spec
link into this subdirectory.

Follow-up to #27174.
@foolip
Copy link
Member Author

foolip commented Jan 14, 2021

I've sent #27187 for further consolidation, but as a draft as I need to make sure I didn't break any tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where to move vendor-imports/mozilla/mozilla-central-reftests/align3?
4 participants