nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c #109309

jonringer · 2021-01-13T19:40:43Z

Motivation for this change

update nixUnstable

~~had to pin gcc to gcc9 as additional work was merged since the last update which is not compatible. Pragmatically, we can bump to gcc10 when upstream has CI around gcc10~~

Using the version of nixUnstable which hydra is using. and just picked the patches that I really want to use.

Things done

Ma27 · 2021-01-13T20:48:44Z

Last time I checked the current hydra-unstable in here didn't build with latest Nix master. Can you please check if bumping Hydra would resolve the issue?

Also, this should be backported IMHO.

jonringer · 2021-01-13T23:59:23Z

updating hydra to latest, then picking what the flake.lock is locked to

jonringer · 2021-01-14T00:08:22Z

https://github.com/NixOS/nixpkgs/pull/109309

1 package marked as broken and skipped:
nix-exec

1 package failed to build:
hercules-ci-agent

53 packages built:
bundix cabal2nix cachix common-updater-scripts crate2nix crystal2nix dep2nix disnix disnixos dydisnix fusionInventory go2nix hydra-unstable libnixxml lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-direnv nix-doc nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update nix-update-source nixFlakes nixos-generators nixos-shell nixui python37Packages.nix-kernel python37Packages.nixpkgs python37Packages.pythonix python38Packages.nix-kernel python38Packages.nixpkgs python38Packages.pythonix python39Packages.nix-kernel python39Packages.nixpkgs python39Packages.pythonix update-nix-fetchgit vgo2nix vulnix

jonringer · 2021-01-14T01:01:18Z

@GrahamcOfBorg build hydra-unstable

SuperSandro2000 · 2021-01-14T14:26:19Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

3 packages marked as broken and skipped:

fusionInventory
nix-exec
nixui

51 packages failed to build and are new build failures:

bundix: log was empty
cabal2nix: log was empty
cachix: log was empty
crate2nix: log was empty
crystal2nix: log was empty
dep2nix: log was empty
disnix: log was empty
dydisnix: log was empty
go2nix: log was empty
haskellPackages.cachix: log was empty
haskellPackages.hercules-ci-agent: log was empty
haskellPackages.nix-paths: log was empty
haskellPackages.update-nix-fetchgit: log was empty
hercules-ci-agent: log was empty
libnixxml: log was empty
nix: log https://termbin.com/wn4l
(nixStable): log was empty
nix-bundle: log was empty
nix-direnv: log was empty
nix-doc: log was empty
nix-du: log was empty
nix-index: log was empty
nix-pin: log was empty
nix-plugins: log was empty
nix-prefetch-bzr: log was empty
nix-prefetch-cvs: log was empty
nix-prefetch-docker: log was empty
nix-prefetch-git: log was empty
nix-prefetch-hg: log was empty
nix-prefetch-scripts: log was empty
nix-prefetch-svn: log was empty
nix-serve: log was empty
nix-update: log was empty
nix-update-source: log was empty
nixFlakes: log https://termbin.com/h2iy
(nixUnstable): log was empty
nixos-generators: log was empty
nixos-shell: log was empty
nixpkgs-review: log was empty
python37Packages.nix-kernel: log was empty
python37Packages.nixpkgs: log was empty
python37Packages.pythonix: log was empty
python38Packages.nix-kernel: log was empty
python38Packages.nixpkgs: log was empty
python38Packages.pythonix: log was empty
python39Packages.nix-kernel: log was empty
python39Packages.nixpkgs: log was empty
python39Packages.pythonix: log was empty
update-nix-fetchgit: log was empty
vgo2nix: log was empty
vulnix: log was empty

jonringer · 2021-01-14T16:53:48Z

gah, darwin :(

SuperSandro2000 · 2021-01-14T18:52:12Z

gah, darwin :(

It is already broken now and I think some tests are failing. We should fix it eventually.

jonringer · 2021-01-14T18:58:12Z

Yea, but the current darwin build is passing https://hydra.nixos.org/build/135058690 so I don't want to break darwin users. Especially since this should be backported.

Wish darwin wasn't so expensive to get CI for. (Free for linux)

jonringer · 2021-01-19T21:41:43Z

looks like NixOS/nix@86a2cee was merged which would allow me to revert gcc version pinning

Ma27 · 2021-01-27T14:42:12Z

if we can't merge this because of darwin yet, we should at least apply the patch from NixOS/nix#4470.

jonringer · 2021-02-03T06:41:10Z

reverted the gcc9 change, because it's no longer relevant, may also fix the darwin build

added the related flake inputs changes which I cared about and attempted to open this PR in the first place

@SuperSandro2000 do you mind doing a darwin review?

jonringer · 2021-02-03T06:48:02Z

https://github.com/NixOS/nixpkgs/pull/109309

1 package marked as broken and skipped:
nix-exec

1 package failed to build:
hercules-ci-agent

51 packages built:
bundix cabal2nix cachix common-updater-scripts crate2nix crystal2nix dep2nix fusionInventory go2nix hydra-unstable libnixxml lispPackages.quicklisp-to-nix lispPackages.quicklisp-to-nix-system-info nix nix-binary-cache nix-bundle nix-direnv nix-doc nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-review nix-serve nix-update nix-update-source nixFlakes nixos-generators nixos-rebuild nixos-shell nixui python37Packages.nix-kernel python37Packages.nixpkgs python37Packages.pythonix python38Packages.nix-kernel python38Packages.nixpkgs python38Packages.pythonix python39Packages.nix-kernel python39Packages.nixpkgs python39Packages.pythonix update-nix-fetchgit vgo2nix vulnix

hercules-ci-agent is already broken on master

SuperSandro2000 · 2021-02-03T12:55:41Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

4 packages failed to build and are new build failures:

nix-update: log was empty
nixFlakes: log https://termbin.com/ha8z
(nixUnstable): log was empty
nixpkgs-review: log was empty

Not sure if this is related to the sandbox or not.

Edit: it is not.

SuperSandro2000 · 2021-02-03T17:33:38Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109309 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

2 packages failed to build and are new build failures:

haskellPackages.hercules-ci-agent: log https://termbin.com/veld
hercules-ci-agent: log https://termbin.com/j26h

53 packages built:

bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
libnixxml
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

jonringer · 2021-02-03T18:36:13Z

I think that failure has been a long time flakey issue

can you try to build it again?

Ma27 · 2021-02-03T19:01:01Z

Can confirm. I regularly compile Nix on my own since I have a few patches on top and this is one of the tests that fail from time to time.

SuperSandro2000 · 2021-02-04T12:28:51Z

can you try to build it again?

I have build it at least two times with that issue.

jonringer · 2021-02-04T15:21:21Z

can you try to build it again?

I have build it at least two times with that issue.

I had another coworker be able to build it fine. I might just merge and babysit, restarting it.

jonringer · 2021-02-09T17:17:43Z

cc @edolstra @Ma27 do you mind if I pin the nix version for hydra, and the nixUnstable package can more closely follow the development branch?

Ma27 · 2021-03-08T20:32:30Z

Don't have the capacity to test (tonight at least in my tz), but LGTM 👍

Ma27

@jonringer LGTM, can be merged from my PoV 👍

SuperSandro2000 · 2021-03-10T23:27:23Z

@ofborg eval

SuperSandro2000 · 2021-03-10T23:39:21Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109309 run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

3 packages failed to build and already failed to build on hydra master:

haskellPackages.hercules-ci-agent: log was empty
hercules-ci-agent: log was empty
libnixxml: log was empty

50 packages built:

bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.hercules-ci-cnix-store
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hydra-unstable
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

SuperSandro2000 · 2021-03-11T00:56:54Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109309 run on x86_64-darwin 1

5 packages failed to build and already failed to build on hydra master:

nix-direnv: log was empty
(nixpkgs-review): log was empty
nix-update: log was empty
nixFlakes: plain log | pretty log
(nixUnstable): log was empty

1 package failed to build and are new build failure:

nix-review: log was empty

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

nix-direnv:

warning: unused-argument
Unused argument: nix.
Near pkgs/tools/misc/nix-direnv/default.nix:1:42:

  |
1 | { lib, stdenv, fetchFromGitHub, gnugrep, nix, nixFlakes }:
  |                                          ^

nixFlakes:

warning: EvalError
Cannot evaluate attribute ‘nixFlakes’ in ‘/nix/store/2pii6w5m7138dxg0vwjaxwnv8d8jrx1p-nixpkgs’.

shlevy · 2021-03-11T13:35:12Z

nixUnstable is now past this.

jonringer · 2021-03-11T19:31:43Z

closing due to other PR

ofborg bot requested a review from edolstra January 13, 2021 21:47

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jan 13, 2021

jonringer force-pushed the bump-nixunstable branch from 0c7ad46 to f86df1a Compare January 13, 2021 23:46

jonringer force-pushed the bump-nixunstable branch from f86df1a to e74a032 Compare January 14, 2021 00:03

jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 14, 2021

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

roberth mentioned this pull request Jan 28, 2021

nixUnstable: patch #4470 (ETag) #111005

Merged

10 tasks

jonringer force-pushed the bump-nixunstable branch 4 times, most recently from 0802e72 to 7deeb4a Compare February 3, 2021 06:27

ofborg bot added 10.rebuild-darwin: 1-10 and removed 2.status: merge conflict 10.rebuild-darwin: 11-100 labels Feb 3, 2021

This comment has been minimized.

Sign in to view

cole-h mentioned this pull request Mar 1, 2021

nixUnstable: 2.4pre20201205_a5d85d0 -> 2.4pre20210308_1c0e3e4 #114786

Merged

10 tasks

Jonathan Ringer added 2 commits March 8, 2021 12:13

nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c

189ca88

hydra-unstable: 2020-10-20 -> 2021-02-19

feb95d9

jonringer force-pushed the bump-nixunstable branch from 174b31c to feb95d9 Compare March 8, 2021 20:14

jonringer changed the title ~~nixUnstable: pre20201205_a5d85d0 -> pre20210113_3da9a92~~ nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c Mar 8, 2021

ofborg bot requested a review from Ma27 March 8, 2021 20:27

Ma27 approved these changes Mar 9, 2021

View reviewed changes

ofborg bot requested a review from Ma27 March 10, 2021 23:40

jonringer closed this Mar 11, 2021

jonringer deleted the bump-nixunstable branch March 11, 2021 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c #109309

nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c #109309

jonringer commented Jan 13, 2021 •

edited

Ma27 commented Jan 13, 2021

jonringer commented Jan 13, 2021

jonringer commented Jan 14, 2021

jonringer commented Jan 14, 2021

SuperSandro2000 commented Jan 14, 2021

jonringer commented Jan 14, 2021

SuperSandro2000 commented Jan 14, 2021

jonringer commented Jan 14, 2021

jonringer commented Jan 19, 2021

Ma27 commented Jan 27, 2021

jonringer commented Feb 3, 2021

jonringer commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021 •

edited

This comment has been minimized.

SuperSandro2000 commented Feb 3, 2021

jonringer commented Feb 3, 2021

Ma27 commented Feb 3, 2021

SuperSandro2000 commented Feb 4, 2021

jonringer commented Feb 4, 2021

jonringer commented Feb 9, 2021

Ma27 commented Mar 8, 2021

Ma27 left a comment

SuperSandro2000 commented Mar 10, 2021

SuperSandro2000 commented Mar 10, 2021

SuperSandro2000 commented Mar 11, 2021

shlevy commented Mar 11, 2021

jonringer commented Mar 11, 2021

nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c #109309

nixUnstable: pre20201205_a5d85d0 -> pre20210219_548437c #109309

Conversation

jonringer commented Jan 13, 2021 • edited

Motivation for this change

Things done

Ma27 commented Jan 13, 2021

jonringer commented Jan 13, 2021

jonringer commented Jan 14, 2021

jonringer commented Jan 14, 2021

SuperSandro2000 commented Jan 14, 2021

jonringer commented Jan 14, 2021

SuperSandro2000 commented Jan 14, 2021

jonringer commented Jan 14, 2021

jonringer commented Jan 19, 2021

Ma27 commented Jan 27, 2021

jonringer commented Feb 3, 2021

jonringer commented Feb 3, 2021

SuperSandro2000 commented Feb 3, 2021 • edited

This comment has been minimized.

SuperSandro2000 commented Feb 3, 2021

jonringer commented Feb 3, 2021

Ma27 commented Feb 3, 2021

SuperSandro2000 commented Feb 4, 2021

jonringer commented Feb 4, 2021

jonringer commented Feb 9, 2021

Ma27 commented Mar 8, 2021

Ma27 left a comment

Choose a reason for hiding this comment

SuperSandro2000 commented Mar 10, 2021

SuperSandro2000 commented Mar 10, 2021

SuperSandro2000 commented Mar 11, 2021

shlevy commented Mar 11, 2021

jonringer commented Mar 11, 2021

jonringer commented Jan 13, 2021 •

edited

SuperSandro2000 commented Feb 3, 2021 •

edited