Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verilator: 4.100 -> 4.108 #109249

Closed
wants to merge 1 commit into from
Closed

verilator: 4.100 -> 4.108 #109249

wants to merge 1 commit into from

Conversation

yangm2
Copy link
Contributor

@yangm2 yangm2 commented Jan 13, 2021

Motivation for this change

Update to newer version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yangm2
Copy link
Contributor Author

yangm2 commented Jan 13, 2021

@thoughtpolice Please have a look and let me know if this looks okay.

@ofborg ofborg bot requested a review from thoughtpolice January 13, 2021 06:05
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109249 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109249 run on x86_64-linux 1

1 package failed to build and are new build failure:

thoughtpolice
thoughtpolice requested changes Jan 15, 2021
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tests still seem to fail. Feel free to fix it if you want, or just skip it...

pkgs/applications/science/electronics/verilator/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from thoughtpolice January 15, 2021 08:02
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109249 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@SuperSandro2000
Copy link
Member

You can remove the patcheshebang if it is only required for darwin and just mark it broken.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109249 run on x86_64-linux 1

1 package failed to build and are new build failure:

@thoughtpolice
Copy link
Member

@yangm2 Thanks again for the PR! I was curious as to why it was failing, and it was because both src/flexfix and src/vlcovgen, which were python scripts, had /usr/env/python as part of their shebang, and obviously this isn't allowed in Nix scripts. The vlcovgen one in particular had me confused; I had to build with -j1 in order to figure it out so the build log came out correctly.

The fix was pretty simple:

  postPatch = ''
    patchShebangs src/vlcovgen src/flexfix
  '';

It also turns out python3 is only needed at build time, so it can be put into nativeBuildInputs.

I've gone ahead and committed these changes as part of c7ebdc8, and pushed them to master, with appropriate attribution — you're still the commit author, with a small Co-authored-by line for myself. So I think this can be closed. Thanks!

@thoughtpolice
Copy link
Member

The most interesting part is that flexfix and vlcovgen have both existed for a while, so it's unclear why they've become problematic now. Who knows!

@yangm2
Copy link
Contributor Author

yangm2 commented Jan 16, 2021

The most interesting part is that flexfix and vlcovgen have both existed for a while, so it's unclear why they've become problematic now. Who knows!

These were only failing when I tried to set doCheck to true ... so with your fix, should doCheck be enabled? With the complexity of a (System)Verilog compiler/simulator, I think it would be good to have the basic install checks enabled.

@yangm2 yangm2 mentioned this pull request Jan 16, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yangm2 @SuperSandro2000 @thoughtpolice @Janik-Haag