Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add a png representation of the palette overlaid with indexes (dec) #8547

Merged

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 9, 2021

Motivation / Problem

Might be useful to have an easy reference to the palette in docs.

Description

There are numerous of these in grf projects, but I use this one which

  • is generated directly from the dos palette using PIL
  • features enlarged blocks for each colour so it's easier to use than most

The overlays are decimal indexes.

Limitations

The overlays are decimal indexes, which makes sense with nml and friends, but for OpenTTD we might prefer hex. I could patch the generator to do that.

Not going to be offended if this PR is rejected as unnecessary.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@andythenorth andythenorth added the work: still in progress (draft) This Pull Request is a draft label Jan 9, 2021
@andythenorth andythenorth force-pushed the dos_palette_representation_decimal branch from 3ba7a05 to 0eff200 Compare January 9, 2021 16:16
@andythenorth andythenorth added needs review and removed work: still in progress (draft) This Pull Request is a draft labels Jan 9, 2021
@SamuXarick
Copy link
Contributor

This was useful for picking a color for the rainforest on minimap PR. Thx

@glx22
Copy link
Contributor

glx22 commented Jan 13, 2021

I'd like to have extra line and column with 0 to F to ease hex based lookup

@TrueBrain TrueBrain merged commit 3345d54 into OpenTTD:master Jan 22, 2021
@TrueBrain
Copy link
Member

I'd like to have extra line and column with 0 to F to ease hex based lookup

I agree that something that indicates hex would make life easier, but honestly, I am already happy to have this image over not having it :D So if @andythenorth feels up for it, see this as a feature-request to extend on the current work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants