Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .window.js for webstorage tests #27176

Merged
merged 2 commits into from Mar 23, 2021
Merged

Use .window.js for webstorage tests #27176

merged 2 commits into from Mar 23, 2021

Conversation

crowlKats
Copy link
Contributor

No description provided.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 20, 2021

Can you split this into two commits: one that moves the files, and one that reindents?

@crowlKats
Copy link
Contributor Author

crowlKats commented Jan 21, 2021 •
edited

Can you split this into two commits: one that moves the files, and one that reindents?

Not sure i understand oh i see. will do it asap

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@crowlKats
Copy link
Contributor Author

god sorry i am messing up with git...

Ms2ger
Ms2ger approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ms2ger Ms2ger merged commit a7ff355 into web-platform-tests:master Mar 23, 2021
@iddm
Copy link

iddm commented Apr 2, 2021

Can you please explain how to run these tests now? I need to run the local_window_open.html but you've refactored it to a javascript code, now I can't run it with my browser, I have to embed it myself into another page.
Another question is, was there a motivation for these changes?

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 2, 2021

You can load X.window.js tests at the corresponding X.window.html URL.

@iddm
Copy link

iddm commented Apr 2, 2021

You can load X.window.js tests at the corresponding X.window.html URL.

I am sorry, can you point to these files that can run these tests? I can't find such files in the repository.
I only see "storage*window.js" files and no storage*window.html files there.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 2, 2021

Some docs here: https://github.com/web-platform-tests/wpt/blob/master/docs/writing-tests/testharness.md#window-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

@andypaicu andypaicu Awaiting requested review from andypaicu

@annevk annevk Awaiting requested review from annevk

@astearns astearns Awaiting requested review from astearns

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@bfgeek bfgeek Awaiting requested review from bfgeek

@birtles birtles Awaiting requested review from birtles

@cbiesinger cbiesinger Awaiting requested review from cbiesinger

@chrishtr chrishtr Awaiting requested review from chrishtr

@christianliebel christianliebel Awaiting requested review from christianliebel

@darrnshn darrnshn Awaiting requested review from darrnshn

@dbaron dbaron Awaiting requested review from dbaron

@deniak deniak Awaiting requested review from deniak

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@domenic domenic Awaiting requested review from domenic

@drott drott Awaiting requested review from drott

Assignees

@siusin siusin

Labels
appmanifest assets Azure Pipelines beacon client-hints clipboard-apis compression conformance-checkers contacts content-security-policy cookies cors-rfc1918 CSS2 css-animations css-backgrounds css-break css-color css-conditional css-contain css-counter-styles css-display css-env css-flexbox css-fonts css-grid css-highlight-api css-images css-layout-api css-lists css-masking css-multicol css-overflow css-overscroll-behavior css-page css-paint-api css-position css-properties-values-api css-pseudo css-ruby css-scoping css-scroll-anchoring css-scroll-snap css-scrollbars css-sizing css-tables css-text css-transforms css-transitions css-typed-om css-ui css-values css-variables css-writing-modes cssom-view fetch FileAPI filter-effects geometry GitHub Actions IndexedDB mediaqueries selectors status:needs-reviewers support vendor-imports webidl webstorage wg-css wg-html wg-svg wg-webapps wg-webperf wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crowlKats @Ms2ger @wpt-pr-bot @iddm @siusin