Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for requestSubmit(null) #27165

Closed
wants to merge 1 commit into from
Closed

Add a test for requestSubmit(null) #27165

wants to merge 1 commit into from

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Jan 13, 2021

This should behave exactly as requestSubmit() behaves.

This should behave exactly as requestSubmit() behaves.
assert_true(event.cancelable);
assert_equals(event.submitter, null);
assert_true(event instanceof SubmitEvent);
}, 'firing an event named submit; form.requestSubmit(null)');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a different name from the test above, no? It seems this would result in a harness error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has a different name :) I added null as parameter in the description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I search for this exact string, line 110 and 123 light up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests are actually identical? Maybe this was already exported somehow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original was added in 61c2804...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I completely missed that somehow! It is good that this is tested, in https://bugs.webkit.org/show_bug.cgi?id=197958 we thought it was not tested. Sorry for the noise!

@rwlbuis rwlbuis closed this Jan 14, 2021
@annevk annevk deleted the request_submit branch January 14, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants