Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenith: 0.11.0 -> 0.12.0 #109311

Merged
merged 1 commit into from Jan 14, 2021
Merged

zenith: 0.11.0 -> 0.12.0 #109311

merged 1 commit into from Jan 14, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 13, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 13, 2021 •
edited

Result of nixpkgs-review pr 109311 run on x86_64-linux 1

1 package built:
  • zenith

Tested and it works.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109311 run on x86_64-linux 1

1 package built:
  • zenith

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109311 run on x86_64-darwin 1

1 package built:
  • zenith

@SuperSandro2000 SuperSandro2000 merged commit 7dd624a into NixOS:master Jan 14, 2021
@SuperSandro2000
Copy link
Member

I ❤️ GitHub auto scrolling.

@bbigras bbigras deleted the zenith branch January 14, 2021 15:32
@bbigras
Copy link
Contributor Author

bbigras commented Jan 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @thiagokokada @SuperSandro2000