Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron_11: 11.1.0 -> 11.2.0 #109290

Merged
merged 1 commit into from Jan 14, 2021
Merged

electron_11: 11.1.0 -> 11.2.0 #109290

merged 1 commit into from Jan 14, 2021

Conversation

TredwellGit
Copy link
Member

Motivation for this change

https://github.com/electron/electron/releases/tag/v11.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@TredwellGit TredwellGit added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
@TredwellGit
Copy link
Member Author

Other Electron updates also need ports to stable:
https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/tools/electron
https://github.com/NixOS/nixpkgs/commits/release-20.09/pkgs/development/tools/electron

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109290 run on x86_64-darwin 1

2 packages built:
  • electron (electron_11)
  • vieb

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109290 run on x86_64-linux 1

5 packages built:
  • _1password-gui
  • electron (electron_11)
  • nix-tour
  • obsidian
  • vieb

@SuperSandro2000 SuperSandro2000 merged commit 67744a8 into NixOS:master Jan 14, 2021
@TredwellGit TredwellGit deleted the electron_11 branch January 14, 2021 06:53
@erictapen
Copy link
Member

@TredwellGit could you elaborate on why this needs a port to stable? I don't see anything security related in the release notes you linked.

@TredwellGit
Copy link
Member Author

electron/electron#27213
https://chromereleases.googleblog.com/2021/01/stable-channel-update-for-desktop.html

This update includes 16 security fixes.

erictapen pushed a commit to erictapen/nixpkgs that referenced this pull request Jan 14, 2021
@TredwellGit @erictapen
electron_11: 11.1.0 -> 11.2.0
d1224b5 
https://github.com/electron/electron/releases/tag/v11.2.0
(cherry picked from commit e6b1439)

Backporting, as this contains a security related chromium bump:
NixOS#109290 (comment)
electron/electron#27213
https://chromereleases.googleblog.com/2021/01/stable-channel-update-for-desktop.html
@erictapen
Copy link
Member

Ah, thanks now I get it.

@erictapen erictapen mentioned this pull request Jan 14, 2021
Merged
10 tasks
erictapen pushed a commit that referenced this pull request Jan 14, 2021
@TredwellGit @erictapen
electron_11: 11.1.0 -> 11.2.0
3d8fa5f 
https://github.com/electron/electron/releases/tag/v11.2.0
(cherry picked from commit e6b1439)

Backporting, as this contains a security related chromium bump:
#109290 (comment)
electron/electron#27213
https://chromereleases.googleblog.com/2021/01/stable-channel-update-for-desktop.html
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TredwellGit @SuperSandro2000 @erictapen @hugolgst