[Gecko Bug 1684909] Add and adjust image-set tests / test expectations. #27167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests uncover two things:
cursor: image-set() doesn't work, because there's no in the
spec: https://drafts.csswg.org/css-ui-4/#cursor
content: image-set() similarly doesn't work. Though in this case the
spec does call for it to work.
The later doesn't work because we don't support the whole syntax
in
content
(so, we don't supportcontent: linear-gradient
or so on).That seems like a separate issue to fix (WebKit does support this).
The former should probably also work (though WebKit only supports URLs
and not other images like gradients... will file a spec issue).
It also caught a bug with first-contentful-paint which I fixed drive-by:
image-set(url(..)) should be considered contentful, just like url(..) is.
The test changes are mostly straight-forward, but two changes are worth
mentioning:
I moved one subtest that tested content: image-set() from
image-set-rendering.html to its own test, so that we can annotate the test
as passing and ensure it doesn't regress (there's no way to annotate a
reftest as "partially passing").
I changed a test that was testing image-set('/images/red.png') as invalid
incorrectly (resolution is optional per spec and behaves like 1x).
Differential Revision: https://phabricator.services.mozilla.com/D100701
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1684909
gecko-commit: 5c7363d33df344a148a63aff09f9c548bbc144ac
gecko-reviewers: dholbert