Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show rainforest under vegetation on small map #8562

Merged
merged 1 commit into from Jan 13, 2021

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 13, 2021

Motivation / Problem

What motivated me to develop this feature was that there was no way to tell apart rainforest land from normal land. I wanted to see how rainforest tiles were generated, but this piece of information was missing in the minimap.

Description

This feature PR marks the small map with tiles that are rainforest land with a paleish green, when the type of small map to display is set to 'Vegetation'. It also adds a legenda named 'Rainforest Land'.

This is how it looks without PR:
rainforest on master

This is how it looks with PR:
rainforest on pr

Limitations

The color I've picked to represent rainforest might not be the ideal one. There could be a better colour.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

glx22
glx22 previously approved these changes Jan 13, 2021
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordAro
Copy link
Member

LordAro commented Jan 13, 2021

"Rainforest Land" to me is redundant - should just be "Rainforest"

@SamuXarick
Copy link
Contributor Author

"Rainforest Land" to me is redundant - should just be "Rainforest"

That was because it may or may not contain trees.

@SamuXarick
Copy link
Contributor Author

Renamed Rainforest Land to Rainforest

@SamuXarick SamuXarick requested a review from glx22 January 13, 2021 15:01
@LordAro LordAro merged commit f9dee5a into OpenTTD:master Jan 13, 2021
@SamuXarick SamuXarick deleted the rainforest-on-smallmap branch January 28, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants