New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: darken the background of all graph to increase contrast #8557
Conversation
Now lines like Mauve, Dark Green and Purple are much more visible without hurting the other colours.
It looks cute :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We talked it over, and having 2 backgrounds for similar windows is even worse (and hard to maintain). We think this improves the situation in most cases, but it indeed is a regression for a select few others. Pretty sure we can never catch them all :)
Themes etc would be nice, but that should be a generic thing, not only for this specific window :)
All nice ideas, but as you might have noticed by now, we are taking one thing at the time, not everything at once :) Otherwise things will never get finished ;) We accept Pull Requests for all these suggestions, as with any other feature request! |
Fixes #8539.
Motivation / Problem
Some company graph colours are very hard to read, making you want to change your company colour.
See #8539 for a detailed explanation.
Description
For the current choice, colours like Mauve, Dark Green and Purple
are nearly invisible in the graphs. Using a darker background
resolves that issue.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.