Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql80: 8.0.17 -> 8.0.22 #109006

Merged
merged 3 commits into from Jan 12, 2021
Merged

mysql80: 8.0.17 -> 8.0.22 #109006

merged 3 commits into from Jan 12, 2021

Conversation

totten
Copy link
Contributor

@totten totten commented Jan 11, 2021

Motivation for this change

This is an updated variation of @alyssais's #93371 for upgrading mysql80:

  • Rebase and resolve merge-conflict
  • Update a little further (8.0.22)
  • Update another problematic reference to /usr/bin/libtool that appears in more recent versions. (I believe this was the cause of the prior build failure on darwin. It now builds on my local darwin box.)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@totten totten mentioned this pull request Jan 11, 2021
Closed
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109006 run on x86_64-darwin 1

2 packages built:
  • libmysqlconnectorcpp
  • mysql80

@bhipple bhipple merged commit 1e678a9 into NixOS:master Jan 12, 2021
@seamuslee001 seamuslee001 mentioned this pull request Jan 13, 2021
Closed
10 tasks
@totten totten deleted the master-mysql-8022 branch December 3, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@totten @SuperSandro2000 @bhipple @alyssais