Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinnwand, steck: update #108998

Merged
merged 2 commits into from Jan 11, 2021
Merged

pinnwand, steck: update #108998

merged 2 commits into from Jan 11, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

New upstream releases

https://github.com/supakeen/pinnwand/releases/tag/v1.2.3
https://github.com/supakeen/steck/releases/tag/v0.7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title Pinnwand pinnwand, steck: update Jan 11, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108998 run on x86_64-linux 1

2 packages built:
  • pinnwand
  • steck

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108998 run on x86_64-darwin 1

1 package failed to build and are new build failure:
1 package built:
  • steck

@SuperSandro2000
Copy link
Member

darwin patch:

diff --git a/pkgs/servers/pinnwand/default.nix b/pkgs/servers/pinnwand/default.nix
index 475e2c228de..807f241fa3e 100644
--- a/pkgs/servers/pinnwand/default.nix
+++ b/pkgs/servers/pinnwand/default.nix
@@ -39,6 +39,8 @@ in with python.pkgs; buildPythonApplication rec {

   checkInputs = [ pytestCheckHook ];

+  __darwinAllowLocalNetworking = true;
+
   passthru.tests = nixosTests.pinnwand;

   meta = with lib; {

@mweinelt
Copy link
Member Author

@SuperSandro2000 test pinnwand

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108998 run on x86_64-darwin 1

2 packages built:
  • pinnwand
  • steck

@SuperSandro2000 SuperSandro2000 merged commit 6bfbb2d into NixOS:master Jan 11, 2021
@mweinelt mweinelt deleted the pinnwand branch January 11, 2021 21:58
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108998 run on x86_64-linux 1

2 packages built:
  • pinnwand
  • steck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @SuperSandro2000