Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg: 2.2.26 -> 2.2.27 #109051

Closed
wants to merge 1 commit into from
Closed

gnupg: 2.2.26 -> 2.2.27 #109051

wants to merge 1 commit into from

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 11, 2021

Announcement: https://lists.gnupg.org/pipermail/gnupg-announce/2021q1/000452.html

Luckily this fixes a regression from GnuPG 2.2.26 that broke the build
of libsForQt5.qgpgme (a test failed). Fix #109009.

Motivation for this change

Normally this should go into staging but since #109009 is currently blocking nixos-unstable we should merge this into master (at least AFAIK).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Jan 11, 2021

@GrahamcOfBorg build libsForQt5.qgpgme

This was referenced Jan 11, 2021
Merged
Closed
@ofborg ofborg bot requested review from vrthra, peti and fpletz January 12, 2021 00:12
@SuperSandro2000
Copy link
Member

/rebase-staging

@primeos @github-actions
gnupg: 2.2.26 -> 2.2.27
971853b 
Announcement: https://lists.gnupg.org/pipermail/gnupg-announce/2021q1/000452.html

Luckily this fixes a regression from GnuPG 2.2.26 that broke the build
of libsForQt5.qgpgme (a test failed). Fix NixOS#109009.
@github-actions github-actions bot changed the base branch from master to staging January 12, 2021 00:55
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 12, 2021 •
edited

I skimmed over the description and just rebased it on staging based on the ofborg labels. I don't want to merge this into master because it is rebuilding almost everything and this will block merging of any PR for at least a day or even longer. If it introduces any regression early in the dependency chain we could get into real trouble.

@SuperSandro2000
Copy link
Member

I discussed this a bit with @petabyteboy on IRC and this should probably go through staging-next instead of directly into master. @FRidh Would that be okay for you?

@ghost
Copy link

ghost commented Jan 12, 2021

I still think this should go to master but I discovered some of us have really different priorities (preventing mass-rebuilds on master versus getting nixos-unstable unblocked asap), which is fully okay.

@FRidh
Copy link
Member

FRidh commented Jan 12, 2021

Thanks. Pushed to master and staging-next.

  • master because, while its a lot of rebuilds, its blocking and the rebuilds are mostly linux, which goes fast
  • staging-next, to avoid further rebuilding with incorrect version

@FRidh FRidh closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@peti peti Awaiting requested review from peti

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qgpgme fails to build (failing test), blocking nixos-unstable
3 participants
@primeos @SuperSandro2000 @FRidh