Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.json-schema-for-humans: 0.27.0 -> 0.27.1 #109053

Merged
merged 1 commit into from Jan 14, 2021
Merged

python3Packages.json-schema-for-humans: 0.27.0 -> 0.27.1 #109053

merged 1 commit into from Jan 14, 2021

Conversation

astro
Copy link
Contributor

@astro astro commented Jan 11, 2021

Motivation for this change

There has been a new release, allowing us to get rid of patches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 11, 2021
View reviewed changes
pkgs/development/python-modules/json-schema-for-humans/default.nix
patches = [ (fetchurl {
url = "https://github.com/coveooss/json-schema-for-humans/commit/1fe2e2391da5a796204fd1889e4a11a53f83f7c9.patch";
sha256 = "0kpydpddlg0rib9snl8albhbrrs6d3ds292gpgpg7bdpqrwamdib";
}) (fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that in the review but in the future please use fetchpatch instead of fetchurl.

Also please remove fetchurl from inputs.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109053 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.json-schema-for-humans
2 packages built:
  • json-schema-for-humans (python38Packages.json-schema-for-humans)
  • python37Packages.json-schema-for-humans

jonringer
jonringer reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.json-schema-for-humans: 0.27.0 -> 0.27.1

@astro
Copy link
Contributor Author

astro commented Jan 13, 2021

Thanks for the reviews.

@SuperSandro2000 SuperSandro2000 changed the title json-schema-for-humans: 0.27.0 -> 0.27.1 python3Packages.json-schema-for-humans: 0.27.0 -> 0.27.1 Jan 14, 2021
@SuperSandro2000 SuperSandro2000 merged commit aa39134 into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @SuperSandro2000 @jonringer