Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rambox: migrate to use AppImage #109020

Merged
merged 1 commit into from Jan 20, 2021
Merged

rambox: migrate to use AppImage #109020

merged 1 commit into from Jan 20, 2021

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 11, 2021 •
edited

Motivation for this change

The motivation comes from PR #108787: AppImage is the official and using it should avoid some issues.

Also, migrating both packages (instead of only rambox-pro like #108787) can make maintaining both packages easier. There is now a mkRambox function that abstract most of the build process.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada thiagokokada mentioned this pull request Jan 11, 2021
Closed
10 tasks
@ofborg ofborg bot requested a review from cawilliamson January 11, 2021 15:44
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109020 run on x86_64-linux 1

2 packages built:
  • rambox
  • rambox-pro

@thiagokokada
rambox: migrate to use AppImage
530f90d 
The motivation comes from PR #108787: AppImage is the official and
using it should avoid some issues.

Also, migrating both packages (instead of only rambox-pro like #108787)
can make maintaining both packages better. There is now a `mkRambox`
function that abstract most of the build process.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109020 run on x86_64-linux 1

1 package built:
  • rambox-pro

@thiagokokada
Copy link
Contributor Author

@SuperSandro2000 Can you merge this?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2021 •
edited

I am not sure if the methodically here is the right one. Also except @Ma27 I couldn't find any of the maintainers.

@cawilliamson
Copy link
Member

This gets a huge thumbs up from me (maintainer of the pro variant of rambox.) 👍

I think ultimately this makes maintaining the package vastly simpler and less problematic. The pro variant of the package has been broken for several weeks now so it needs to be fixed anyway.

cawilliamson
cawilliamson approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@cawilliamson cawilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 100% in favour of this change - has my vote! 👍

@Ma27
Copy link
Member

Ma27 commented Jan 20, 2021

I don't have a strong opinion on this, but has anybody checked whether the new package will preserve the settings from my original rambox? (This was not the case the last time this got repackaged and if this isn't possible, then 👎 from me).

@thiagokokada
Copy link
Contributor Author

@Ma27 Just tested, seems to work fine (tested with rambox and not rambox-pro, but no reason to believe this wouldn't work too since AppImage is not a sandbox system like Snaps or Flatpaks).

@cawilliamson
Copy link
Member

@Ma27 Just tested, seems to work fine (tested with rambox and not rambox-pro, but no reason to believe this wouldn't work too since AppImage is not a sandbox system like Snaps or Flatpaks).

The same applies to rambox-pro - no settings loss at all.

@SuperSandro2000 SuperSandro2000 merged commit e4d01e5 into NixOS:master Jan 20, 2021
@thiagokokada thiagokokada deleted the move-rambox-to-appimage branch January 20, 2021 13:56
@andresilva
Copy link
Member

Opening URLs seems to be broken after migration to AppImage. Also font and cursor config seem to be ignored.

@thiagokokada
Copy link
Contributor Author

@andresilva Can you reproduce this issue with other AppImage programs? If yes, I think it would be better to try to investigate that issue in appImageTools.

Maybe opening an issue?

@andresilva
Copy link
Member

Yeah the issue seems to be related to AppImage packaging and not specific to Rambox. Will have a look.

@andresilva
Copy link
Member

#110636 I have no clue who to ping though. If someone knows who's responsible for maintaining the AppImage packaging support please cc them on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@cawilliamson cawilliamson cawilliamson approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thiagokokada @SuperSandro2000 @cawilliamson @Ma27 @andresilva