linuxPackages.isgx: init at 2.11 #109013

oxalica · 2021-01-11T12:18:26Z

Motivation for this change

Add Linux driver for Intel Software Guard Extention (SGX).
Repository url.

When loaded on supported CPU with SGX enabled in BIOS, /dev/{isgx,mei0} will be available.

Things done

pkgs/os-specific/linux/isgx/default.nix

SuperSandro2000 · 2021-01-11T14:47:51Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109013 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.isgx
linuxPackages_hardkernel_latest.isgx

15 packages failed to build and are new build failures:

linuxPackages-libre.isgx: log was empty
linuxPackages_4_14.isgx: log was empty
linuxPackages_4_19.isgx: log was empty
linuxPackages_4_4.isgx: log was empty
linuxPackages_4_9.isgx: log was empty
linuxPackages_5_10.isgx: log https://termbin.com/kuny
(linuxPackages_latest.isgx): log was empty
linuxPackages_5_9.isgx: log https://termbin.com/8elm
linuxPackages_latest-libre.isgx: log https://termbin.com/r0da
linuxPackages_latest_hardened.isgx: log https://termbin.com/9ph4
linuxPackages_latest_xen_dom0.isgx: log https://termbin.com/rzi8
linuxPackages_latest_xen_dom0_hardened.isgx: log https://termbin.com/7max
linuxPackages_lqx.isgx: log https://termbin.com/ompo
linuxPackages_testing_bcachefs.isgx: log https://termbin.com/t0xj
linuxPackages_zen.isgx: log https://termbin.com/n65s

4 packages built:

linuxPackages.isgx (linuxPackages_5_4.isgx)
linuxPackages_hardened.isgx
linuxPackages_xen_dom0.isgx
linuxPackages_xen_dom0_hardened.isgx

pkgs/os-specific/linux/isgx/default.nix

nixos-discourse · 2021-01-27T20:30:36Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-upstream-a-working-kernel-module-derivation/11040/3

Pacman99 · 2021-01-27T23:07:51Z

I'm getting this error while building this:

error: --- EvalError ------------------------------------------------------- nix
at: (28:13) in file: /home/pachums/.cache/nixpkgs-review/pr-109013/nixpkgs/pkgs/os-specific/linux/isgx/default.nix

    27|     "KDIR=${kernel.dev}/lib/modules/${kernel.modDirVersion}/build"
    28|     "ARCH=${stdenv.hostPlatform.platform.kernelArch}"
      |             ^
    29|   ] ++ lib.optional (stdenv.hostPlatform != stdenv.buildPlatform) [

attribute 'platform' missing
(use '--show-trace' to show detailed location information)

I think this will get fixed by @lzmartinico's suggestion

oxalica · 2021-01-30T06:32:59Z

Rebased and fixed build error.

Mic92 · 2021-01-30T08:43:27Z

pkgs/os-specific/linux/isgx/default.nix

+  meta = with lib; {
+    description = "Intel SGX Linux Driver";
+    homepage = "https://github.com/intel/linux-sgx-driver";
+    license = with licenses; [ bsd3 gpl2 ];


I am inclined to say we no longer need this package because current linux testing adds an upstream sgx driver. Nevertheless you should mark this as broken for kernel newer or equal to 5.11.0.

Btw this is what you need to enable to have it in the kernel: https://github.com/Mic92/doctor-cluster-config/commit/bb70ed032ec876b93e2c4263af3542aa56fd7bdd#diff-d33b7b1f936a6f8f74abe312c8ef8737c4b53a525878f08564a4d0c163f2be5cR15

also gpl2Only or gpl2Plus?

@Mic92 Broken predicate is added. BTW: Kernel 5.11 is not in master currently. I'll check it later.

@SuperSandro2000 It's gpl2Only. Fixed.

oxalica · 2021-02-01T14:13:38Z

It seems that the Makefile doesn't support cross compiling flags. I just removed related codes to simplify.

Mic92 · 2021-02-01T17:41:49Z

Result of nixpkgs-review pr 109013 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxPackages_hardkernel_4_14.isgx
linuxPackages_hardkernel_latest.isgx

1 package failed to build:

linuxPackages-libre.isgx

16 packages built:

linuxPackages.isgx (linuxPackages_5_4.isgx)
linuxPackages_4_14.isgx
linuxPackages_4_19.isgx
linuxPackages_4_4.isgx
linuxPackages_4_9.isgx
linuxPackages_5_10.isgx (linuxPackages_latest.isgx)
linuxPackages_hardened.isgx
linuxPackages_latest-libre.isgx
linuxPackages_latest_hardened.isgx
linuxPackages_latest_xen_dom0.isgx
linuxPackages_latest_xen_dom0_hardened.isgx
linuxPackages_lqx.isgx
linuxPackages_testing_bcachefs.isgx
linuxPackages_xen_dom0.isgx
linuxPackages_xen_dom0_hardened.isgx
linuxPackages_zen.isgx

Mic92 · 2021-02-01T17:42:26Z

Looks like linuxPackages-libre is broken again.

SuperSandro2000 · 2021-02-01T19:16:24Z

Looks like linuxPackages-libre is broken again.

I don't think I have seen it working since I started reviewing.

Mic92 · 2021-02-02T14:38:42Z

Looks like linuxPackages-libre is broken again.

I don't think I have seen it working since I started reviewing.

#111594

oxalica · 2021-02-05T11:50:09Z

@Mic92 Can we have this merged now?

adaszko · 2021-03-31T07:59:46Z

@Mic92 Can we have this merged now?

+1. Is there something that's blocking this? Is help needed for something?

SuperSandro2000 · 2021-03-31T23:33:12Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109013 run on x86_64-linux 1

10 packages marked as broken and skipped:

linuxPackages-libre.isgx
linuxPackages_hardkernel_4_14.isgx
linuxPackages_hardkernel_latest.isgx
linuxPackages_latest-libre.isgx
linuxPackages_latest.isgx
linuxPackages_latest_hardened.isgx
linuxPackages_latest_xen_dom0.isgx
linuxPackages_latest_xen_dom0_hardened.isgx
linuxPackages_lqx.isgx
linuxPackages_zen.isgx

10 packages built:

linuxPackages.isgx (linuxPackages_5_10.isgx)
linuxPackages_4_14.isgx
linuxPackages_4_19.isgx
linuxPackages_4_4.isgx
linuxPackages_4_9.isgx
linuxPackages_5_4.isgx
linuxPackages_hardened.isgx
linuxPackages_testing_bcachefs.isgx
linuxPackages_xen_dom0.isgx
linuxPackages_xen_dom0_hardened.isgx

nixos-discourse · 2021-04-12T14:21:45Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/overriding-patchflags-in-buildlinux/6316/2

adaszko · 2021-06-12T08:52:51Z

This kernel module loads up fine for me with insmod: /root/.nix-profile/lib/modules/5.10.40/kernel/drivers/intel/sgx/isgx.ko but doesn't autoload on boot, even though I have boot.kernelModules = [ "isgx" ]; in /etc/nixos/configuration.nix. It errors during boot:

% journalctl -b | grep sgx
Jun 12 10:48:09 pierun systemd-modules-load[1647]: Failed to find module 'isgx'

oxalica · 2021-06-12T14:34:23Z

@adaszko The module is not in-tree. I think you need to add the package to boot.extraModulePackages and then enable it in boot.kernelModules.

adaszko · 2021-06-12T14:48:53Z

Correct, this has worked for me:

boot.extraModulePackages = with config.boot.kernelPackages; [ isgx ];

Thanks!

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Jan 11, 2021

SuperSandro2000 reviewed Jan 11, 2021

View reviewed changes

pkgs/os-specific/linux/isgx/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jan 11, 2021

View reviewed changes

pkgs/os-specific/linux/isgx/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jan 11, 2021

View reviewed changes

pkgs/os-specific/linux/isgx/default.nix Outdated Show resolved Hide resolved

lzmartinico reviewed Jan 27, 2021

View reviewed changes

pkgs/os-specific/linux/isgx/default.nix Outdated Show resolved Hide resolved

linuxPackages.isgx: init at 2.11

2ae97b9

oxalica force-pushed the isgx branch from e252450 to 2ae97b9 Compare January 30, 2021 06:31

Mic92 reviewed Jan 30, 2021

View reviewed changes

oxalica added 2 commits February 1, 2021 22:04

isgx: simplify

0ed888f

isgx: fix meta and mark as broken for kernel >= 5.11.0

5d5ed1a

SuperSandro2000 merged commit 72e1e31 into NixOS:master Mar 31, 2021

oxalica deleted the isgx branch April 1, 2021 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linuxPackages.isgx: init at 2.11 #109013

linuxPackages.isgx: init at 2.11 #109013

oxalica commented Jan 11, 2021

SuperSandro2000 commented Jan 11, 2021

nixos-discourse commented Jan 27, 2021

Pacman99 commented Jan 27, 2021 •

edited

oxalica commented Jan 30, 2021

Mic92 Jan 30, 2021 •

edited

Mic92 Jan 30, 2021

SuperSandro2000 Jan 31, 2021

oxalica Feb 1, 2021

oxalica commented Feb 1, 2021

Mic92 commented Feb 1, 2021

Mic92 commented Feb 1, 2021

SuperSandro2000 commented Feb 1, 2021

Mic92 commented Feb 2, 2021

oxalica commented Feb 5, 2021

adaszko commented Mar 31, 2021

SuperSandro2000 commented Mar 31, 2021

nixos-discourse commented Apr 12, 2021

adaszko commented Jun 12, 2021

oxalica commented Jun 12, 2021

adaszko commented Jun 12, 2021

linuxPackages.isgx: init at 2.11 #109013

linuxPackages.isgx: init at 2.11 #109013

Conversation

oxalica commented Jan 11, 2021

Motivation for this change

Things done

SuperSandro2000 commented Jan 11, 2021

nixos-discourse commented Jan 27, 2021

Pacman99 commented Jan 27, 2021 • edited

oxalica commented Jan 30, 2021

Mic92 Jan 30, 2021 • edited

Choose a reason for hiding this comment

Mic92 Jan 30, 2021

Choose a reason for hiding this comment

SuperSandro2000 Jan 31, 2021

Choose a reason for hiding this comment

oxalica Feb 1, 2021

Choose a reason for hiding this comment

oxalica commented Feb 1, 2021

Mic92 commented Feb 1, 2021

Mic92 commented Feb 1, 2021

SuperSandro2000 commented Feb 1, 2021

Mic92 commented Feb 2, 2021

oxalica commented Feb 5, 2021

adaszko commented Mar 31, 2021

SuperSandro2000 commented Mar 31, 2021

nixos-discourse commented Apr 12, 2021

adaszko commented Jun 12, 2021

oxalica commented Jun 12, 2021

adaszko commented Jun 12, 2021

Pacman99 commented Jan 27, 2021 •

edited

Mic92 Jan 30, 2021 •

edited