Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.iproute2mac: update to 1.3.0 #109003

Closed
wants to merge 1 commit into from
Closed

darwin.iproute2mac: update to 1.3.0 #109003

wants to merge 1 commit into from

Conversation

holymonson
Copy link
Contributor

Motivation for this change

Update darwin.iproute2mac to 1.3.0 . This may be marked as insecure because network_cmds-osx-10.11.6 is still using openssl-1.0.2u, which should be fixed by #101229 .

CC @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 11, 2021
@ofborg ofborg bot requested a review from flokli January 11, 2021 08:45
@SuperSandro2000
Copy link
Member 

error: derivation '/nix/store/4a20gq8x0ykmrvymymqkr85kdmp42njf-iproute2mac-1.3.0.drv' requested impure path '/usr/bin/sudo', but it was not in allowed-impure-host-deps

@holymonson
Copy link
Contributor Author 

error: derivation '/nix/store/4a20gq8x0ykmrvymymqkr85kdmp42njf-iproute2mac-1.3.0.drv' requested impure path '/usr/bin/sudo', but it was not in allowed-impure-host-deps

sudo is broken on darwin. In fact, it can be built, but failed to run because

❯ ./result/sbin/sudo
sudo: ./result/sbin/sudo must be owned by uid 0 and have the setuid bit set

So it seems we have to use the system-shipped impure one. Should we add it to allowed-impure-host-deps?

@flokli
Copy link
Contributor

flokli commented Jan 12, 2021

@holymonson would you be willing to take over maintainership here? I don't really have a device to properly test this on…

@SuperSandro2000
Copy link
Member

Should we add it to allowed-impure-host-deps?

I am not sure.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109003 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • darwin.iproute2mac

@holymonson
Copy link
Contributor Author

This PR is finished but will still be marked insecure, let's keep it drafted until #101229 and #109626 fixed.

@holymonson holymonson marked this pull request as draft January 22, 2021 09:21
@abathur abathur mentioned this pull request May 26, 2021
Closed
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@jiegec jiegec mentioned this pull request Jun 24, 2022
Merged
13 tasks
@flokli
Copy link
Contributor

flokli commented Jun 27, 2022

Closing, #178822 has been merged.

@flokli flokli closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holymonson @SuperSandro2000 @flokli