uutils: 2019-05-03 -> 0.0.2 #109025
uutils: 2019-05-03 -> 0.0.2 #109025
Conversation
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
| }; | ||
| in |
There was a problem hiding this comment.
Please remove that let in.
There was a problem hiding this comment.
Is there a reason for that other than your personal preference?
There was a problem hiding this comment.
This is how we do it in nixpkgs. Doing let in is usually only done when fetching extra sources.
There was a problem hiding this comment.
Is there a reason for that other than your personal preference?
There is no good reason to use a let in here. rec is shorter, cleaner, easier to understand even for non functional programmers and more commonly used which makes it easier to do treewide changes against it. Please change it.
|
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually. |
| }; | ||
| in |
There was a problem hiding this comment.
Is there a reason for that other than your personal preference?
There is no good reason to use a let in here. rec is shorter, cleaner, easier to understand even for non functional programmers and more commonly used which makes it easier to do treewide changes against it. Please change it.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)