Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] coturn: apply patch for CVE-2020-26262 #109043

Merged
merged 2 commits into from Jan 14, 2021
Merged

[20.09] coturn: apply patch for CVE-2020-26262 #109043

merged 2 commits into from Jan 14, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jan 11, 2021 •
edited

Motivation for this change

Related to #109038

Fixes CVE-2020-26262.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Jan 11, 2021

I am not liking that we backport new features with this release. Are they optional? If so, can we keep them disabled? Otherwise we can always just apply this patch:
https://github.com/coturn/coturn/commit/abfe1fd08d78baa0947d17dac0f7411c3d948e4d.patch

@0x4A6F 0x4A6F force-pushed the release-20.09-coturn branch 2 times, most recently from b6120fa to 1d91947 Compare January 11, 2021 19:54
@0x4A6F 0x4A6F changed the title [20.09] coturn: 4.5.1.3 -> 4.5.2 [20.09] coturn: apply patch for CVE-2020-26262 Jan 11, 2021
@SuperSandro2000
Copy link
Member

If so, can we keep them disabled?

Why should we disable features?

The release also contained two nullpointer dereferences. I would prefer shipping an official version instead of a custom patched one even if it container a feature or two.

@ofborg ofborg bot requested a review from Ralith January 11, 2021 22:56
@symphorien
Copy link
Member

I tested coturn with the patch, it works.
Are SRI hashes allowed on 20.09?

@symphorien
Copy link
Member

@GrahamcOfBorg build coturn

@symphorien symphorien merged commit ccdf756 into NixOS:release-20.09 Jan 14, 2021
@0x4A6F 0x4A6F mentioned this pull request Jan 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @andir @SuperSandro2000 @symphorien