Fix type error in ec2.nix and overly strict typing in route53_recordset.nix #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adisbladis @AmineChikhaoui Is there anything left to do here? |
A record set should be able to point to a machine regardless of where it's deployed.
Instead of expecting the root device to always be the first item in an AMI's `BlockDeviceMappings`, find the one matching the `RootDeviceName`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a type error in
ec2.nixAllow any machine to be used in a Route53 record set, not just EC2 machines
Currently, the nix option type allows any machine to be specified, but the python code expects an EC2 machine, resulting in a deadlock when an unexpected machine type is used.