Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] amazonImage: Upload disks as GP3 for cheaper & faster IO #109028

Merged
merged 1 commit into from Jan 11, 2021
Merged

[20.09] amazonImage: Upload disks as GP3 for cheaper & faster IO #109028

merged 1 commit into from Jan 11, 2021

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 11, 2021

GP3 is always faster and cheaper than GP2, so sticking to GP2 is
leaving money on the table.

https://cloudwiry.com/ebs-gp3-vs-gp2-pricing-comparison/
(cherry picked from commit 98eca2c)

Backport of #109027

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
amazonImage: Upload disks as GP3 for cheaper & faster IO
06c6de4 
GP3 is always faster and cheaper than GP2, so sticking to GP2 is
leaving money on the table.

https://cloudwiry.com/ebs-gp3-vs-gp2-pricing-comparison/
(cherry picked from commit 98eca2c)
@grahamc grahamc changed the title amazonImage: Upload disks as GP3 for cheaper & faster IO [20.09] amazonImage: Upload disks as GP3 for cheaper & faster IO Jan 11, 2021
@grahamc grahamc merged commit b5e9f8b into NixOS:release-20.09 Jan 11, 2021
@grahamc grahamc deleted the 20.09-gp3 branch January 11, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineChikhaoui AmineChikhaoui AmineChikhaoui approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @AmineChikhaoui