Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: add sqlite_unlock_notify build tag #109037

Merged
merged 1 commit into from Jan 12, 2021
Merged

gitea: add sqlite_unlock_notify build tag #109037

merged 1 commit into from Jan 12, 2021

Conversation

zeripath
Copy link
Contributor

Motivation for this change

Fix #109004

When building Gitea with sqlite support the sqlite_unlock_notify tag must also be added otherwise there will be frequent error reports of database is locked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zeripath
gitea: add sqlite_unlock_notify build tag
0e0900c 
Fix #109004

When building Gitea with sqlite support the sqlite_unlock_notify tag must also be added otherwise there will be frequent error reports of database is locked.
jonringer
jonringer approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
tests pass

@Ma27 Ma27 merged commit 0ac27f8 into NixOS:master Jan 12, 2021
@sbourdeauducq
Copy link
Contributor

This should be applied to 20.09 as well.

@Ma27
Copy link
Member

Ma27 commented Jan 12, 2021

Already on it.

@Ma27
Copy link
Member

Ma27 commented Jan 12, 2021

Ported to stable as ac88b30.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 12, 2021
@zeripath zeripath deleted the gitea-add-sqlite-unlock-notify branch January 12, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@jonringer jonringer jonringer approved these changes

@kolaente kolaente Awaiting requested review from kolaente

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sqlite needs sqlite_unlock_notify tag to prevent deadlock
5 participants
@zeripath @sbourdeauducq @Ma27 @jonringer @Janik-Haag