Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More code cleanups in video drivers #8740

Merged
merged 3 commits into from Feb 24, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

While working on another PR, I had to synchronize a few more things between the different video drivers. Without that PR, these are already helping to make the video drivers a bit more the same.

Description

  • PollEvent was doing nearly the same on different drivers, but with different return values.
  • InteractiveRandom was called in the MainLoop but can be done from Tick too (deduplication)
  • OSX has a weird quirk

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

…l drivers

Additionally, call it from the draw-tick.
MainLoop() is used to bootstrap OSX, where later a callback is
done to GameLoop() to execute OpenTTD. All other video drivers
don't need that, so what is in GameLoop is in MainLoop for all
other drivers. This is rather confusing. So, instead, name
GameLoop MainLoopReal to be more in sync with the other drivers.
@TrueBrain TrueBrain merged commit 6a8c461 into OpenTTD:master Feb 24, 2021
@TrueBrain TrueBrain deleted the more-video-cleanup branch February 24, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants