Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8734: [OpenGL] Apply palette remap to cursor sprites. #8742

Merged
merged 1 commit into from Feb 24, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Feb 24, 2021

Motivation / Problem

Palette remap was not applied to cursor sprites when using OpenGL.

Description

Change shader code to apply palette remap.

Limitations

Transparent palette remap is not implemented, but not used for cursor sprites. The shader code is also not very optimised, which should not pose a problem for the average pixel amount in a cursor sprite.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc merged commit e1e8cc3 into OpenTTD:master Feb 24, 2021
@michicc michicc deleted the pr/gl_cursor_remap branch February 24, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants